1550109 - HTML validation, required fields, regex for website address

Status: RESOLVED FIXED

(Firefox :: about:logins, enhancement, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Editing a LoginItem should have basic validation of the hostname, username, and password. We should require that all fields are filled. Hostnames should validate as a URL object.

Comment 1

[Matthew N. [:MattN]]

<input type="url" required>

would be a good starting point for origin validation… it doesn't seem to require a trailing slash which is good.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550109 - Add default styling for input[type=url] to common.inc.css. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550109 - Add support for required modal-input values. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550109 - Require the origin and password when creating a new login. r?MattN

Validation constraints and errors need to be surfaced still. Some of this work could be pushed to bug 1550122.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1550109 - Add tests for required fields of the login-item. r?MattN

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30ce578fc33c
Add default styling for input[type=url] to common.inc.css. r=MattN
https://hg.mozilla.org/integration/autoland/rev/f51914dc71e3
Add support for required modal-input values. r=MattN
https://hg.mozilla.org/integration/autoland/rev/e292d1c1e2f1
Require the origin and password when creating a new login. r=MattN,Pike
https://hg.mozilla.org/integration/autoland/rev/a121178c0634
Add tests for required fields of the login-item. r=MattN

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/30ce578fc33c
https://hg.mozilla.org/mozilla-central/rev/f51914dc71e3
https://hg.mozilla.org/mozilla-central/rev/e292d1c1e2f1
https://hg.mozilla.org/mozilla-central/rev/a121178c0634

Comment 8

[Florencia Di Ciocco, NI to vbalducci]

Hi Jared Wein,

Could you please tell me the steps to reproduce the bug, please?

Thanks in advance, Flor.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Work in this area is still too early for QE verification.