Closed Bug 1556934 Opened 4 months ago Closed 3 months ago

Don't include paths in the origin field of manually added logins

Categories

(Toolkit :: Password Manager, defect, P1, major)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: MattN, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline] )

Attachments

(4 files)

Bug 1550109 used type=url but didn't enforce that the URL was an origin without a path component. This is important to fix to not get invalid data in storage and Sync which will cause us pain for years to come in bug reports.

Flags: qe-verify-

Additional work to include when fixing this bug per UX review,

  • Add placeholder text in fields
  • Add extra help text next to field matching add-on style, though consider making it less jargony.
  • Use https:// as the default if the user specifies a path that doesn't include a scheme
  • Remove red error state on fields on page load, wait for the user to put something invalid
  • Remove all asterisks on field, prompt as required fields if they fail to enter
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01491e20dc1e
Don't include the paths in the origin field of manually added logins. r=MattN
https://hg.mozilla.org/integration/autoland/rev/ec8a1f1e2786
Remove the asterisk from the required fields. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/a672a53ba4dd
Add placeholder text in fields and preprend https:// if scheme is not provided for origin. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/595066673cf0
Don't show invalid form field styling on inputs before the user has modified them or submitted the form. r=MattN

Backed out 8 changesets (bug 1556934, bug 1553209) for build bustages at modal-input.js on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/8ac8a1e12af9ecdf0c50e8d1579df23b417c4e7c

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=fdd0795fa469f2401eac8675a200f506ab2dd2d3&selectedJob=251892728

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251892728&repo=autoland&lineNumber=36614

Log snippet:

[task 2019-06-14T14:22:58.910Z] 14:22:58 INFO - package-tests> make[2]: Entering directory '/builds/worker/workspace/build/src/obj-firefox'
[task 2019-06-14T14:22:58.910Z] 14:22:58 INFO - package-tests> /builds/worker/workspace/build/src/obj-firefox/_virtualenvs/init/bin/python -m mozbuild.action.process_install_manifest --track install__test_files.track _tests _build_manifests/install/_test_files
[task 2019-06-14T14:22:58.910Z] 14:22:58 ERROR - package-tests> Traceback (most recent call last):
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> "main", fname, loader, pkg_name)
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> exec code in run_globals
[task 2019-06-14T14:22:58.911Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 114, in <module>
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> main(sys.argv[1:])
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 100, in main
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> defines=args.defines)
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozbuild/action/process_install_manifest.py", line 69, in process_manifest
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> remove_empty_directories=remove_empty_directories)
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/copier.py", line 432, in copy
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> copy_results.append((destfile, f.copy(destfile, skip_if_older)))
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/files.py", line 357, in copy
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> raise ErrorMessage('Symlink target path does not exist: %s' % self.path)
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> mozpack.errors.ErrorMessage: Symlink target path does not exist: /builds/worker/workspace/build/src/browser/components/aboutlogins/content/components/modal-input.js
[task 2019-06-14T14:22:58.912Z] 14:22:58 INFO - package-tests> Makefile:123: recipe for target 'install-test-files' failed
[task 2019-06-14T14:22:58.912Z] 14:22:58 ERROR - package-tests> make[2]: *** [install-test-files] Error 1

Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/584df985f41c
Don't include the paths in the origin field of manually added logins. r=MattN
https://hg.mozilla.org/integration/autoland/rev/890a9618182a
Remove the asterisk from the required fields. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/deae0e180c09
Add placeholder text in fields and preprend https:// if scheme is not provided for origin. r=MattN,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/0084058b039c
Don't show invalid form field styling on inputs before the user has modified them or submitted the form. r=MattN
Flags: needinfo?(jaws)
Whiteboard: [passwords:management] [skyline]
You need to log in before you can comment on or make changes to this bug.