Make the spinbuttons a real widget

RESOLVED FIXED

Status

SeaMonkey
Themes
--
minor
RESOLVED FIXED
15 years ago
3 years ago

People

(Reporter: John Dobbins, Assigned: Neil Deakin)

Tracking

(Blocks: 1 bug)

Dependency tree / graph
Bug Flags:
blocking-aviary1.5 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments, 2 obsolete attachments)

(Reporter)

Description

15 years ago
spinbuttons.css refers to icons that are no longer there.

In Classic,
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/spinbuttons.css
and
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/spinbuttons.css
have referances like this
.up {
  list-style-image: url("chrome://global/skin/spinbtn-up.gif")
}
All icons were removed from the global directory in December. No new directory
was created to hold these icons.

In Modern,
http://lxr.mozilla.org/seamonkey/source/themes/modern/global/spinbuttons.css
refers to
.up {
  list-style-image: url("chrome://global/skin/spinbuttons/btn-up.gif");
}
There is no spinbuttons directory holding these icons.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 1

15 years ago
Hakan, can you help us with the missing images? Thanks.

Comment 2

15 years ago
This did work, I know glazou used the spinbuttons widget in his XUL application;
someone broke it, and it sure wasn't me! :-)

CC'ing some random people, does anyone have any idea?
Yes, I do use spinbuttons

Comment 4

15 years ago
Hakan or Daniel, can one of you guys please commit the missing images into the
tree, this way we can have a go with the buttons, I don't have a clue what they
do/can do yet.
(Reporter)

Comment 5

14 years ago
Created attachment 133331 [details]
spinbtn-dn.gif
(Reporter)

Comment 6

14 years ago
Created attachment 133332 [details]
spinbtn-dn-act.gif
(Reporter)

Comment 7

14 years ago
Created attachment 133333 [details]
spinbtn-up.gif
(Reporter)

Comment 8

14 years ago
Created attachment 133334 [details]
spinbtn-up-act.gif
(Reporter)

Comment 9

14 years ago
I Found Copies of the missing icons and added attached them to this bug.
Taking bug
Assignee: shliang → daniel

Comment 11

13 years ago
This should so be done with CSS borders and backgrounds.
(In reply to comment #11)
> This should so be done with CSS borders and backgrounds.

Right.

Comment 13

12 years ago
*** Bug 276146 has been marked as a duplicate of this bug. ***

Comment 14

12 years ago
I'm going ask for 1.1 blocking on a couple of spinbutton bugs.  We have been
trying to use them in our ForcastFox extension, but they won't theme correctly
since we have to supply our own images.
Flags: blocking-aviary1.1?

Updated

12 years ago
Flags: blocking-aviary1.1? → blocking-aviary1.1-

Comment 15

12 years ago
*** Bug 319088 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 16

11 years ago
Morphing this bug into one about making the <spinbuttons/> a real XUL element with  propery properties, methods and events, etc.

Assignee: daniel → enndeakin
Blocks: 260487
Summary: Spinbutton icons missing in Classic and Modern skins. → Make the spinbuttons a real widget
(Assignee)

Comment 17

11 years ago
Created attachment 225034 [details] [diff] [review]
native theme changes for spinbuttons
Attachment #225034 - Flags: superreview?(roc)
Attachment #225034 - Flags: review?(roc)
(Assignee)

Comment 18

11 years ago
Created attachment 225036 [details] [diff] [review]
Add spinbuttons widget
Attachment #225036 - Flags: review?(neil)

Comment 19

11 years ago
I can't see any code that draws the spinbuttons on Windows 2000 or BeOS?
(Assignee)

Comment 20

11 years ago
Created attachment 226165 [details] [diff] [review]
Add images for other platforms

Added to Windows spinbuttons.css, but otherwise unchanged.

The only issue is that for xpfe, the spinbuttons appears too tall, but I can't figure out what the reason for that is. Different images, maybe?
Attachment #225036 - Attachment is obsolete: true
Attachment #226165 - Flags: review?(neil)
Attachment #225036 - Flags: review?(neil)
Comment on attachment 225034 [details] [diff] [review]
native theme changes for spinbuttons

mostly a rubber-stamp...
Attachment #225034 - Flags: superreview?(roc)
Attachment #225034 - Flags: superreview+
Attachment #225034 - Flags: review?(roc)
Attachment #225034 - Flags: review+

Comment 22

11 years ago
(In reply to comment #20)
>The only issue is that for xpfe, the spinbuttons appears too tall, but I can't
>figure out what the reason for that is. Different images, maybe?
You're using the 11x11 arrow images that Classic has. Strangely on my XP build the spinbuttons has a height of 22. Where did the borders go? I'm worried that the native theme code is overriding the border size even when it's not painting.

Comment 23

11 years ago
I removed the -moz-appearance and it makes makes things look as expected.
I'd say that's bad :-(
Obviously if I was using Luna then I would expect it to override the size.

Comment 24

11 years ago
The Modern styles are forcing the image to be 2px high which seems odd.
(Assignee)

Comment 25

11 years ago
Created attachment 228842 [details] [diff] [review]
fix sizing issues

- fix up modern theme appearance
- for Classic themes, use background images for spinbuttons rather than list-style-images
Attachment #226165 - Attachment is obsolete: true
Attachment #228842 - Flags: superreview?(neil)
Attachment #228842 - Flags: review?(neil)
Attachment #226165 - Flags: review?(neil)

Comment 26

11 years ago
Comment on attachment 228842 [details] [diff] [review]
fix sizing issues

Well the good news is that the Modern theme looks quite nice. However, I'd say the Classic theme still has issues.
* I hunted around my RH7.3 linux box for some spinbuttons and found some that were 15x22 so I'm not sure where your dimensions came from.
* On Windows 2000, or Windows XP with Classic theme, the default height of the spinbuttons is zero. That's right, you don't even get any borders.
* On either platform, if you disable (or don't have) themeing (I do this because I don't like the GTK native themeing) then you do get to see the borders, but you have to set a height to see the arrows.
* Once I'd done that I noticed that an odd width looks better. In fact I'd say an odd width looks better in Modern too.
Attachment #228842 - Flags: superreview?(neil)
Attachment #228842 - Flags: superreview+
Attachment #228842 - Flags: review?(neil)
Attachment #228842 - Flags: review-
(Assignee)

Comment 27

11 years ago
Created attachment 228991 [details] [diff] [review]
Fix issues described above by setting a minimum height

The spinbuttons look the right size on my FC4 system, comparing to various preference panels. Are you using gtk1?
Attachment #228991 - Flags: review?(neil)

Comment 28

11 years ago
Comment on attachment 228991 [details] [diff] [review]
Fix issues described above by setting a minimum height

Still hacky but at least it works...
Attachment #228991 - Flags: review?(neil) → review+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 29

11 years ago
So it looks as if the problem with the Classic theme was that when Classic themeimg was first written not all of the Classic* functions were implemented for spinbuttons, in they are given neither size, border nor background.
Product: Core → SeaMonkey

Updated

9 years ago
Blocks: 467901
You need to log in before you can comment on or make changes to this bug.