155053 - Make the spinbuttons a real widget

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[John Dobbins]

spinbuttons.css refers to icons that are no longer there.

In Classic,
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/mac/spinbuttons.css
and
http://lxr.mozilla.org/seamonkey/source/themes/classic/global/win/spinbuttons.css
have referances like this
.up {
  list-style-image: url("chrome://global/skin/spinbtn-up.gif")
}
All icons were removed from the global directory in December. No new directory
was created to hold these icons.

In Modern,
http://lxr.mozilla.org/seamonkey/source/themes/modern/global/spinbuttons.css
refers to
.up {
  list-style-image: url("chrome://global/skin/spinbuttons/btn-up.gif");
}
There is no spinbuttons directory holding these icons.

Comment 1

[HJ]

Hakan, can you help us with the missing images? Thanks.

Comment 2

[Håkan Waara]

This did work, I know glazou used the spinbuttons widget in his XUL application;
someone broke it, and it sure wasn't me! :-)

CC'ing some random people, does anyone have any idea?

Comment 3

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Yes, I do use spinbuttons

Comment 4

[HJ]

Hakan or Daniel, can one of you guys please commit the missing images into the
tree, this way we can have a go with the buttons, I don't have a clue what they
do/can do yet.

Comment 5

[John Dobbins]

Attachment: spinbtn-dn.gif

Comment 6

[John Dobbins]

Attachment: spinbtn-dn-act.gif

Comment 7

[John Dobbins]

Attachment: spinbtn-up.gif

Comment 8

[John Dobbins]

Attachment: spinbtn-up-act.gif

Comment 9

[John Dobbins]

I Found Copies of the missing icons and added attached them to this bug.

Comment 10

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Taking bug

Comment 11

[[e-mail]]

This should so be done with CSS borders and backgrounds.

Comment 12

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to comment #11)
> This should so be done with CSS borders and backgrounds.

Right.

Comment 13

[[e-mail]]

*** Bug 276146 has been marked as a duplicate of this bug. ***

Comment 14

[Richard Klein]

I'm going ask for 1.1 blocking on a couple of spinbutton bugs.  We have been
trying to use them in our ForcastFox extension, but they won't theme correctly
since we have to supply our own images.

Comment 15

[zug_treno]

*** Bug 319088 has been marked as a duplicate of this bug. ***

Comment 16

[Neil Deakin]

Morphing this bug into one about making the <spinbuttons/> a real XUL element with  propery properties, methods and events, etc.

Comment 17

[Neil Deakin]

Attachment: native theme changes for spinbuttons

Comment 18

[Neil Deakin]

Attachment: Add spinbuttons widget

Comment 19

[[e-mail]]

I can't see any code that draws the spinbuttons on Windows 2000 or BeOS?

Comment 20

[Neil Deakin]

Attachment: Add images for other platforms

Added to Windows spinbuttons.css, but otherwise unchanged.

The only issue is that for xpfe, the spinbuttons appears too tall, but I can't figure out what the reason for that is. Different images, maybe?

Comment 21

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 225034 [details] [diff] [review]
native theme changes for spinbuttons

mostly a rubber-stamp...

Comment 22

[[e-mail]]

(In reply to comment #20)
>The only issue is that for xpfe, the spinbuttons appears too tall, but I can't
>figure out what the reason for that is. Different images, maybe?
You're using the 11x11 arrow images that Classic has. Strangely on my XP build the spinbuttons has a height of 22. Where did the borders go? I'm worried that the native theme code is overriding the border size even when it's not painting.

Comment 23

[[e-mail]]

I removed the -moz-appearance and it makes makes things look as expected.
I'd say that's bad :-(
Obviously if I was using Luna then I would expect it to override the size.

Comment 24

[[e-mail]]

The Modern styles are forcing the image to be 2px high which seems odd.

Comment 25

[Neil Deakin]

Attachment: fix sizing issues

- fix up modern theme appearance
- for Classic themes, use background images for spinbuttons rather than list-style-images

Comment 26

[[e-mail]]

Comment on attachment 228842 [details] [diff] [review]
fix sizing issues

Well the good news is that the Modern theme looks quite nice. However, I'd say the Classic theme still has issues.
* I hunted around my RH7.3 linux box for some spinbuttons and found some that were 15x22 so I'm not sure where your dimensions came from.
* On Windows 2000, or Windows XP with Classic theme, the default height of the spinbuttons is zero. That's right, you don't even get any borders.
* On either platform, if you disable (or don't have) themeing (I do this because I don't like the GTK native themeing) then you do get to see the borders, but you have to set a height to see the arrows.
* Once I'd done that I noticed that an odd width looks better. In fact I'd say an odd width looks better in Modern too.

Comment 27

[Neil Deakin]

Attachment: Fix issues described above by setting a minimum height

The spinbuttons look the right size on my FC4 system, comparing to various preference panels. Are you using gtk1?

Comment 28

[[e-mail]]

Comment on attachment 228991 [details] [diff] [review]
Fix issues described above by setting a minimum height

Still hacky but at least it works...

Comment 29

[[e-mail]]

So it looks as if the problem with the Classic theme was that when Classic themeimg was first written not all of the Classic* functions were implemented for spinbuttons, in they are given neither size, border nor background.