260487 - spinbuttons does not handle this object correctly; inheritence problem.

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Michael (GoodWill)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.3) Gecko/20040917 Firefox/0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.7.3) Gecko/20040917 Firefox/0.10

Inheritence is not propagated right on the spinnbuttons widget (both in spfe and
in widgets). The "this" object should be returning spinbutton object/element
when execute from onup, ondown methods. Instead it returns the internal
xul:image that contains the images for up button, down button. In addition the
xul:image should probably be anonymous (now they are named upButton and
downButton respectively)

Reproducible: Always
Steps to Reproduce:
1. create foo.xul document, with a <window><hbox> tags and add stylesheet ref to
chrome://communicator/skin/
2. inside <hbox> add <spinbuttons id="foo" onup="alert(this.id)"
ondown="alert(this.id)"/> 
3. open foo.xul and clin on the image representing up and down spin buttons.

Actual Results:  
the alert message returns: "upButton" when "onup" executes, and "downButton"
when clicked "ondown" executes.

Expected Results:  
return the id of the spinbutton, that is "foo". In fact the this object should
also be returning the spinnbutton element with its properties and attributes and
etc.

Comment 1

[Michael (GoodWill)]

glazou said he will to r= this.

Comment 2

[Michael (GoodWill)]

glazou said he will to r= this.

http://lxr.mozilla.org/aviarybranch/source/xpfe/global/resources/content/bindings/spinbuttons.xml#29
http://lxr.mozilla.org/aviarybranch/source/toolkit/content/widgets/spinbuttons.xml#29

Comment 3

[Boris Zbarsky [:bzbarsky]]

Confirming. The problem is that the "onup" is implemented as an event handler on
the underlying image (inherited).  It should be implemented via the onclick
handler on the spinbutton itself (which will check the event target, etc).

Comment 4

[[e-mail]]

As an alternative, would <spinbuttons id="foo" onclick="alert(this.id + '
clicked ' + event.target.className);"/> be any use?

Comment 5

[Michael (GoodWill)]

(In reply to comment #4)
> As an alternative, would <spinbuttons id="foo" onclick="alert(this.id + '
> clicked ' + event.target.className);"/> be any use?

Yeah its possible to have to work around, which is how I did it. 

Comment 6

[Michael (GoodWill)]

not clear which methods and properties spinbuttons should have. so I hesitate to
write a patch.

Comment 7

[Richard Klein]

I'm going ask for 1.1 blocking on a couple of spinbutton bugs.  We have been
trying to use them in our ForcastFox extension, but they won't theme correctly
since we have to supply our own images.

Comment 8

[Neil Deakin]

This was fixed by bug 155053