Closed Bug 1550692 Opened 5 months ago Closed 5 months ago

Process subsection headers in about:telemetry should be clear that they're about processes

Categories

(Toolkit :: Telemetry, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: gfritzsche, Assigned: MonikaMaheshwari, Mentored)

References

Details

(Whiteboard: [good second bug][lang=js])

Attachments

(3 files)

Looking at the new improved process display in about:telemetry, i was wondering:

  1. As a new user of about:telemetry, looking at the list of Main on the left ((a) in the screenshot), how can i tell what Main means?
  2. There is also a process selector at the top right ((b) in the screenshot) - is it different, do we still need it?

For 1. i could imagine:

  • Using "Main process", "Content process" etc. instead of just "Main", "Content".
  • Adding tooltips "Data for the main process", etc.

I think I can understand your confusion, as that's not actually the new all-process display. Please see attached.

I think the new design addresses your concern by

  1. Using the proper process type names ("parent" instead of "main")
  2. Having a new label at the top-right identifying that the selector is for the current "store"

Will that address your concerns?

Flags: needinfo?(gfritzsche)

Thanks for clarifying, that's much better indeed!

One issue that is not covered there though is this:

  1. As a new user of about:telemetry, looking at the list of Main on the left ((a) in the screenshot), how can i tell what Main means?

The same question remains for me, what does "Parent" mean?

Flags: needinfo?(gfritzsche)
Depends on: 1437446

ni?chutten to make this mentored

Flags: needinfo?(chutten)

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions:
  3. Start working on this bug. You'll be taking the process type names we are using as subsection header names here and suffixing them with the string " Process" so that they read like "Parent Process" and "Dynamic Process" and so forth. To make this localizable you'll be using functions provided by Fluent, so you might find its docs to be helpful. I'm not 100% sure, but it looks as though this section is most relevant and you'll be using the setAttributes API to pass the process name to the localized string pattern. See, for example, how we use it to build the phrase "Sorry! There are no results in Histograms for “asdf”" here.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC most hours of most days.
  4. Build your change with mach build and test your change by running your built Firefox with mach run and checking that the subsections render properly. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Mentor: chutten
Flags: needinfo?(chutten)
Priority: -- → P3
Summary: Enhancements to process display in about:telemetry → Process subsection headers in about:telemetry should be clear that they're about processes
Whiteboard: [good second bug][lang=js]

Hey, can I work on this issue?

Certainly! I have assigned it to you. Let me know if you have any questions.

Assignee: nobody → monikamaheshwari1996
Status: NEW → ASSIGNED

Hi,

  1. Using the proper process type names ("parent" instead of "main")
  2. Having a new label at the top-right identifying that the selector is for the current "store"

This are the things I need to change right?

Nope! Those two things should already be happening. What you need to do is spelled out in 3. in comment #5

In short, you'll be taking the process type name (things like "parent", "content", "gpu") and turning them into more specific labels like "parent process" and "gpu process" (basically just putting "process" at the end).

This page is localized, so there's some detail work on how to make it translateable.

Sounds good?

Hi, can you review the patch.

Flags: needinfo?(chutten)

Yes, certainly. I apologize for the delay, Monday was a holiday so I wasn't around to look into it.

Flags: needinfo?(chutten)
Attachment #9065869 - Attachment description: Bug:1550692 Process subsection headers in about:telemetry should be clear that they're about processes → Bug 1550692 Process subsection headers in about:telemetry should be clear that they're about processes

For next contributions after this one, if you're interested to continue on the trend of "making about:telemetry better" there are bug 1394755, bug 1394763, and bug 1394764 that have varying levels of design, architecture, investigation, and implementation work.

Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/916a05c96ee2
Process subsection headers in about:telemetry should be clear that they're about processes r=chutten,flod
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
QA Whiteboard: [qa-69b-p2]
You need to log in before you can comment on or make changes to this bug.