1550737 - Follow up comments on RDD shutdown async patch

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

This implement some comments provided after landing on Bug 1545416.

Comment 1

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=18eec5ab14d033fe3179879ef7300ee88bc4807d

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1550737 - Make sure we keed strong reference until the end of the method. r?jya.

Instead of deleteing a RefPtr directly copy it in a local variable in order to ensure that the pointer will be alive till the end of the method. In addition to that, on RemoteMediaDataDecpder::Shutdown promise use a reference of the child object instead of the whole self object since this is the only one needed. Finally, one style change.

Comment 3

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d895521780c0cfb8e466b6a38189d39badf33d3a

Comment 4

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aa093db0d9d25552393a27e018a76aa4bf83b33

Comment 5

[Alex Chronopoulos [:achronop]]

I am getting some try failures on this. The problem I am observing is that the promise returned from RemoteMediaDataDecoder::Shutdown can be resolved before the promise returned RemoteMediaDataDecoder::Init when the call to RMDD::Shutdown is right after RMDD::Init.

Comment 6

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05c0e29fd97be0fa5338c5359ac796b2b5a0ee74

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1550737 - When shutdown is finished use only a reference of the child. r?jya

When RemoteMediaDataDecoder::Shutdown is finished it is not necessary to hold a reference of the self any more. Keep the mChild alive, which is the only one needed to destroy the IPDL. In addition to that, deleting the IPDL and destroying the child will be happening at the task queue similar to what was happening before Bug 1545416.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4bbc018fe90
Make sure we keed strong reference until the end of the method. r=jya.
https://hg.mozilla.org/integration/autoland/rev/5ba6d20ec80a
When shutdown is finished use only a reference of the child. r=jya

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d4bbc018fe90
https://hg.mozilla.org/mozilla-central/rev/5ba6d20ec80a