1550748 - [meta] version-control-tools cleanups

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, task)

Description

[Connor Sheehan [:sheehan]]

There is a lot of code in version-control-tools that could use a cleanup and/or is candidate for removal. Off the top of my head:

• some dead server extensions (ie from the MozReview days; overlay, manualoverlay) that can be removed
• some bitrotted client extensions (bzpost, bzexport, mqext, q{backout,importbz}) that should be removed or cleaned up
• dead test code (especially some unnecessary docker image builds in the test suite, like bmo)
• lots of compatibility code spread throughout the codebase. These are annotated with # TRACKING hgxx for the most part.

Filing this bug to track cleanups to the repo.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: hgext: remove `checkpystyle` extension (Bug 1550748) r?glob

Removing this extension as it has not been updated since Mercurial
4.2 was released, it is not installed in configwizard and it is
not recommended for use.

Comment 2

[Connor Sheehan [:sheehan]]

Attachment: hgext: remove mq related extensions (Bug 1550748, Bug 1543544) r?glob

Core mq has been deprecated for ages, so our helper
extensions should also be deprecated. This commit removes
the mq related extensions from version-control-tools.

Comment 3

[Connor Sheehan [:sheehan]]

Attachment: hgmo: remove wire protocol v2 hacks (Bug 1550748) r?smacleod

After landing much of the wire protocol v2 work upstream, we
started finding lots of bugs and patching over them in v-c-t,
with the intent of finding more issues and fix them upstream
after some experimentation. Since there are no plans to continue
working on this for the time being, I'm removing it, as well as
some of the related tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/0faaa3ff617b
hgmo: remove wire protocol v2 hacks r=smacleod

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/a1c86717d010
hgext: remove `checkpystyle` extension r=glob
https://hg.mozilla.org/hgcustom/version-control-tools/rev/b3a88dcabb6c
hgext: remove mq related extensions (Bug 1550748, Bug 1543544) r=glob

Comment 6

[Botond Ballo [:botond]]

Any reason hg reviewers was removed? While it lived in mqext, it wasn't actually related to mq, and it was quite useful: given a file, it listed people who reviewed changes to that file, sorted by number of changes reviewed.

Comment 7

[Connor Sheehan [:sheehan]]

Ah, you're right. I filed bug 1592429 to track restoring it.

Comment 8

[Mitchell Hentges [:mhentges] 🦀]

Attachment: hgext: remove logic and tests that depend on mq (Bug 1550748) r=sheehan

Many tests used "mq" for its "strip" command, so this commit updates them to use the "strip" extension directly. Also, this removes logic from various extensions that handled mq-specific cases

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

There's still a lot of references in the docs to mq, but I'm assuming we're going to want to keep that for another little while

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/02c8b7c3087d
hgext: remove logic and tests that depend on mq r=sheehan

Comment 11

[Mitchell Hentges [:mhentges] 🦀]

Attachment: extensions: removes references to q{backout, importbz} (Bug 1550748)

qbackout and qimportbz have been removed, so documenting them under the list of extensions isn't necessary anymore.
Also removes references from moz.build

Comment 12

[Mitchell Hentges [:mhentges] 🦀]

What work still needs to be done for this ticket?
What's the oldest hg version we support? I looked through the # TRACKING notes in the repo, and the oldest targeted version is hg46.

Other than that, is there anything else in particular that this ticket wants to resolve?

Comment 13

[Mitchell Hentges [:mhentges] 🦀]

Attachment: cleanup: removes unused moz.build file (Bug 1550748) r?sheehan

After a brief discussion with sheehan, we don't believe that this file is used, so it should be safe to remove

Depends on D59770

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/339673c2cf98
extensions: removes references to q{backout, importbz} r=sheehan
https://hg.mozilla.org/hgcustom/version-control-tools/rev/91c861abdaa1
cleanup: removes unused moz.build file r=sheehan

Comment 15

[Mitchell Hentges [:mhentges] 🦀]

Attachment: cleanup: removes old supervisor reference from kafka role (Bug 1550748) r?sheehan

An old TODO by gps recommends removing an ansible task that would remove an obsolete supervisor config, this accomplishes that

Comment 16

[Connor Sheehan [:sheehan]]

(In reply to Mitchell Hentges [:mhentges] from comment #12)

What work still needs to be done for this ticket?

Most of the stuff listed in the bug description is finished. We could reasonably close it out now.

What's the oldest hg version we support? I looked through the # TRACKING notes in the repo, and the oldest targeted version is hg46.

The oldest version we support is supposed to be 4.9. Some things like robustcheckout still have support for older versions since our CI hasn't been updated to a newer Mercurial in some time (which I'm working on at the moment).

Other than that, is there anything else in particular that this ticket wants to resolve?

The specific things we wanted resolved are in the description - other than that, attaching random other cleanups here is fine.

Comment 17

[Mitchell Hentges [:mhentges] 🦀]

Ok, I'll mark this as closed, while allowing some other various cleanups to keep being associated with the same bug id 👍

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/9649f2b8577f
cleanup: removes old supervisor reference from kafka role r=sheehan