1551055 - StoragePrincipal should be supported by localStorage

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[Andrea Marchesini [:baku]]

Currently we expose a PartitionedLocalStorage which doesn't share data and it's not built on top of storagePrincipal. We should have a better implementation here.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1551055 - StoragePrincipal should be supported by localStorage - part 1, r?asuth

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 1551055 - StoragePrincipal should be supported by localStorage - part 2 - tests, r?asuth

Depends on D30801

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1551055 - StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r?asuth

Depends on D30802

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d99a6769beb4
StoragePrincipal should be supported by localStorage - part 1, r=asuth
https://hg.mozilla.org/integration/autoland/rev/8727e61ab69b
StoragePrincipal should be supported by localStorage - part 2 - tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/21e44ad9c6df
StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r=asuth

Comment 5

[Andrei Ciure[:aciure]]

Backed out 3 changesets (bug 1551055) for causing xpcshell localStorage perma failures

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=21e44ad9c6df3e31355ab73e4fdfb23be8fe255b

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=abaf133a405518a1c014b704c4fe72dc27a018c1&selectedJob=246178745&searchStr=linux%2Cx64%2Cquantumrender%2Cdebug%2Cxpcshell%2Ctests%2Ctest-linux64-qr%2Fdebug-xpcshell-e10s-2%2Cx%28x2%29

backout: https://hg.mozilla.org/integration/autoland/rev/5abfe3566f38af45a7ef67964d10f8b501ba90f6

Comment 6

[Andrei Ciure[:aciure]]

It also affects mochitests:

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=abaf133a405518a1c014b704c4fe72dc27a018c1&selectedJob=246178794&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-e10s-11%2Cm%28bc11%29

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=abaf133a405518a1c014b704c4fe72dc27a018c1&selectedJob=246178650&searchStr=os%2Cx%2C10.10%2Cdebug%2Cmochitests%2Cwithout%2Ce10s%2Ctest-macosx64%2Fdebug-mochitest-chrome-1proc-2%2Cm-1proc%28c2%29

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/386a0b72c793
StoragePrincipal should be supported by localStorage - part 1, r=asuth
https://hg.mozilla.org/integration/autoland/rev/df4c74e2ecf7
StoragePrincipal should be supported by localStorage - part 2 - tests, r=asuth
https://hg.mozilla.org/integration/autoland/rev/83e3da605798
StoragePrincipal should be supported by localStorage - part 3 - Validate storagePrincipal, r=asuth

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/386a0b72c793
https://hg.mozilla.org/mozilla-central/rev/df4c74e2ecf7
https://hg.mozilla.org/mozilla-central/rev/83e3da605798