1551081 - New calendar event does not respect the date assigned in the "Until" drop-down

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Arthur K. (he/him)]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.57

Steps to reproduce:

Using 67.0b3 x64, I created a new calendar event that would repeat daily and go until June 15th.

Actual results:

I chose June 15th and clicked OK but Until shows "Forever" as the Until end date.

Expected results:

I chose June 15th and clicked OK and it should have set June 15th as the Until end date.

Comment 1

[WaltS48 [:walts48]]

Calendar bugs belong to the Calendar product.

https://bugzilla.mozilla.org/describecomponents.cgi?product=Calendar

Just tested this in TB 67.0b3 with Lightning 6.9 on Ubuntu 18.04.2 LTS and can confirm it happening there.

Also occurs using TB 68.0a1 with Lightning 7.0a1.

Comment 2

[Stefan Sitter [:ssitter]]

If you choose Custom... from the Repeat drop-down menu and use the Until field in the Edit Occurrence dialog it works correctly. Seems that only the Until field in the Edit Event dialog is somehow broken.

Comment 3

[WaltS48 [:walts48]]

Works correctly with Thunderbird 66.0b3 and Lightning 6.8. Build ID 20190306001450

Built from https://hg.mozilla.org/releases/comm-beta/rev/33baca79596d084f20a58dbf017f8bf4757cdeb1

Fails with Thunderbird 67.0b1 and Lightning 6.9. Build ID 20190401164849

Built from https://hg.mozilla.org/releases/comm-beta/rev/a8ed741351316da0077a5536dd3ab88bce52653e

HTH

Comment 4

[Alice0775 White]

There are at least 2 regressions.
#1 regression
Good -> Bad("Until" filed cannot be changed. i.e. "Forever" only selectable)

#2 regression
-> Bad("Until" field can be changed. however, it will be saved as "Forever")

#1 regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=92d2f773019421012e3ce9dd328ead287f9a930c&tochange=ede5d521aad133f5422fb328cb69abc2e76a510c
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=afa70e5e516abf11f4760b915c0b3d09bc351147&tochange=3bf0b7e7e89a005cbe843681384d49227f83a287

#2 regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=672ec0c7864b3248102005f588fb2fb7b74b3bbe&tochange=3958330210079f900dc3bda64de3559e9f4ba4c0
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf3951daded0b4fefd0fc81ee22ce5d536df2099&tochange=bf3951daded0b4fefd0fc81ee22ce5d536df2099

Comment 5

[Alice0775 White]

Suspect:
Bug 1523384 and Bug 1524456

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1551081-forever-1.diff

Two things are going on here:

• When changing value from "forever", the dialog was listening for the command event, which isn't fired, so I changed it to listen for change.
• When changing to "forever", the change event wasn't fired either.

Comment 7

[Geoff Lankow (:darktrojan)]

Thanks Alice, I'm not surprised by that regression window at all.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bd8dc610ca34
Fix setting event repeat-until date. r=philipp