1551229 - Web Authentication Direct Attestations don't work on Android Fennec

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P1)

Description

[J.C. Jones [:jcj] (he/they)]

Testing of WebAuthn interfaces show that everything seems to work except demanding a Direct attestation, where nothing happens.

Example:

• Enable fido2 android pref
• Go to webauthn.io
• For Attestation Type, choose Direct
• Register

Nothing happens. It should work.

Comment 1

[J.C. Jones [:jcj] (he/they)]

The code that blocks on a UX prompt for a Direct Attestation has to be disabled for Android. Android has no UX at present, so until Bug 1550164 resolves, we'll just have to let direct attestations be handled by the Android-provided UX.

Comment 2

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1551229 - Anonmyize all 'direct' attestation requests on Android r=keeler

The code that blocks on a UX prompt for a Direct Attestation has to be disabled
for Android, as Android has no UX at present. Until Bug 1550164 resolves,
we'll have to let direct attestations be downgraded to anonymized ("None")
attestations.

Comment 3

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1551229 - Make it easier to test Android WebAuthn in local builds r=keeler

Depends on D31360

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0887a64bb5f
Anonmyize all 'direct' attestation requests on Android r=keeler

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b0887a64bb5f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31953bf83dfd
Make it easier to test Android WebAuthn in local builds r=keeler

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

Did a push to try before backing out.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=954db4de7ada133092f1dab197ac561600ad2ba5&selectedJob=247111926

Backed out changeset 31953bf83dfd (Bug 1551229) for Bugzilla lint failuires

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=31953bf83dfd9710390419a006d41c51ff61b101&tochange=c1e088ef0311bfe7db4ec3e26b86ce389a95277b&selectedJob=247086317

Backout link: https://hg.mozilla.org/integration/autoland/rev/c1e088ef0311bfe7db4ec3e26b86ce389a95277b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247086317&repo=autoland&lineNumber=194

[vcs 2019-05-17T17:44:11.726Z] updating [================================================> ] 272000/276879 01s
[vcs 2019-05-17T17:44:21.694Z]
[vcs 2019-05-17T17:44:21.694Z] 276879 files updated, 0 files merged, 0 files removed, 0 files unresolved
[vcs 2019-05-17T17:44:21.978Z] updated to 31953bf83dfd9710390419a006d41c51ff61b101
[vcs 2019-05-17T17:44:21.982Z] PERFHERDER_DATA: {"framework": {"name": "vcs"}, "suites": [{"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "clone", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 126.12949419021606}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "update", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 49.984090089797974}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 176.2576129436493}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall_clone", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 176.2576129436493}, {"extraOptions": ["c3.2xlarge"], "lowerIsBetter": true, "name": "overall_clone_fullcheckout", "serverUrl": "us-east-1.hgmointernal.net", "shouldAlert": false, "subtests": [], "value": 176.2576129436493}]}
[vcs 2019-05-17T17:44:22.272Z] TinderboxPrint:<a href=https://us-east-1.hgmointernal.net/integration/autoland/rev/31953bf83dfd9710390419a006d41c51ff61b101 title='Built from autoland revision 31953bf83dfd9710390419a006d41c51ff61b101'>31953bf83dfd9710390419a006d41c51ff61b101</a>
[task 2019-05-17T17:44:22.272Z] executing ['bash', '-cx', 'cd $GECKO_PATH && ./mach file-info bugzilla-automation /builds/worker/artifacts']
[task 2019-05-17T17:44:22.274Z] + cd /builds/worker/checkouts/gecko
[task 2019-05-17T17:44:22.274Z] + ./mach file-info bugzilla-automation /builds/worker/artifacts
[task 2019-05-17T17:45:15.067Z] WARNING: Not a supported OS_TARGET for NSPR in moz.build: "". Use --with-system-nspr
[task 2019-05-17T17:45:17.453Z] WARNING: Cpu arch is not expected
[task 2019-05-17T17:45:17.453Z] WARNING: Stack alignment cannot be zero.
[taskcluster:error] Task timeout after 2700 seconds. Force killing container.
[taskcluster 2019-05-17 18:26:25.279Z] === Task Finished ===
[taskcluster 2019-05-17 18:26:25.280Z] Unsuccessful task run with exit code: -1 completed in 2725.523 seconds

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3e9a5ca0599
Make it easier to test Android WebAuthn in local builds r=keeler

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

Just re-landed this. Bugzilla lint was still orange on the backout.

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e3e9a5ca0599

Comment 11

[J.C. Jones [:jcj] (he/they)]

All good, it seems!