1551359 - Fill cards with longer excerpts for shorter titles

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ed Lee :Mardak]

Attachment: existing clamp 3 always

Cards currently have at most 6 lines -- 3 for title and 3 for excerpt. If the title uses fewer, there can be blank space.

Similarly lists with excerpts seem to be 4 lines and split 2/2.

Comment 1

[Ed Lee :Mardak]

Attachment: card: clamp total 6

Comment 2

[Ed Lee :Mardak]

Attachment: list: clamp total 4

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5025

Comment 4

[Wolasi :wolasi]

What does this look like for the 3 column card grid?

Comment 5

[Ed Lee :Mardak]

Attachment: 3-column grid (and 4-): clamp total 6

All these screenshots haven't implemented the 5-title 6-total that you suggested on slack. These are all 3-title 6-total.

Comment 6

[Wolasi :wolasi]

Comment on attachment 9064633 [details]
list: clamp total 4

Looks good

Comment 7

[Wolasi :wolasi]

Comment on attachment 9065427 [details]
3-column grid (and 4-): clamp total 6

Clamp looks good here. Is the 5-title max 6-total for cards out of scope for this bug? If so, let’s  file another bug for it.

Comment 8

[Ed Lee :Mardak]

Attachment: card: total 6 with at least 1 line for each

I completely rewrote the clamping to support "take up as many lines while keeping at least 1 for excerpt" as the behavior is a bit different from the current behavior of only allowing 3 for the title.

Comment 9

[Ed Lee :Mardak]

Attachment: simulated longer titles (doubled)

Comment 10

[Wolasi :wolasi]

Comment on attachment 9065614 [details]
card: total 6 with at least 1 line for each

Let’s go with the following

*Cards and Hero*
4 line max for title, 2 line minimum for excerpt (6 
Ines total)

*List with Excerpt*
3 line max fo excerpt (4 line total)

Comment 11

[Ed Lee :Mardak]

What changed since you last said to go with Let’s go with title taking (max-1) lines and the excerpt taking at least one line I already rewrote the implementation twice for the previous two, so I guess I'll do it again…

Comment 12

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f78634b8bff9

Comment 13

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that cards use more lines for descriptions if the title allows it on the latest Firefox Nightly 68.0a1 (Build ID 20190519213707) on Windows 10, macOS 10.14, and Arch Linux 4.14.3.