1551554 - The Client ID is not added to the Search URL for the Russian region

Status: RESOLVED FIXED

(Firefox :: Search, defect, P1)

Description

[Rares Doghi, Desktop QA]

[Affected versions]
Firefox 68.0a1

[Affected platforms]
Ubuntu 16.04, Windows 7/10, Mac OS 10.13

[Steps to reproduce]

1. Open the Firefox Russian Localized Build.
2. Have the Region in about:config set to RU.
3. Have the Yandex default search engine and search any word.

[Expected result]
The Client Id "clid=2186621" is added to the search URL

[Actual result]
The URl search does not contain the Client ID for Russia.

Please note that the same issue occurs on a Turkish build with the VPN set to Turkey and region set to TR.

Comment 1

[Dale Harvey (:daleharvey)]

lol I was writing a test to ensure we were sending the right codes and ran into that, debugging it right now

Depending on how big the fix is I will probably dupe this to https://bugzilla.mozilla.org/show_bug.cgi?id=1541415, but will take it for now and leave it in case I need to land the tests without this fixed first

Comment 2

[Dale Harvey (:daleharvey)]

ok this is because we are missing trailing underscores @ https://searchfox.org/mozilla-central/source/browser/components/search/extensions/yandex/manifest.json#31 so the code is not localised

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1551554 - Fix broken webextension localisation keys. r?Standard8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4eff561d2e8
Fix broken webextension localisation keys. r=Standard8

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b4eff561d2e8

Comment 6

[Rares Doghi, Desktop QA]

Hi, I have retested this issue and if I copy the prefs.js file that has the RU region set to a new profile and start it then it works correctly, It does not however work when the user starts the profile changes the region to RU from about config and then restarts the browser. In older versions this worked.

This also works if you Update a build from april 3rd to the latest 69 while the RU region is set.

Dale can you please take a look and tell me if this is intended behavior ?

Comment 7

[Dale Harvey (:daleharvey)]

The issue that got fixed was quite clear and had a subsequent test that verified it

I cant reproduce your issue but what you describe is different from this one, if you are using the built in Yandex engine it should be sending codes in builds since this landed

If you can reproduce please file a new bug and cc/needinfo me enabling |browser.search.log = true| would be extremely useful, cheers

Comment 8

[Dale Harvey (:daleharvey)]

Comment on attachment 9065556 [details]
Bug 1551554 - Fix broken webextension localisation keys. r?Standard8

Beta/Release Uplift Approval Request

• User impact if declined: Not much, we send the wrong codes to search engines so impact is for mozilla
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Switch build to russian and search with Yandex, observe whether or not referal codes are sent
• List of other uplifts needed: Bug 1541415
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Comes with additional tests, can only break whether or not codes are sent
• String changes made/needed:

Comment 9

[Rares Doghi, Desktop QA]

Hi Dale, I retested this issue and I can't reproduce the issue I mentioned, I think its because If you manually change the region to RU the Search preference does not change to Yandex automatically and I might have been searching with google that time. I will Mark this issue accordingly, This issue is Verified as Fixed in 69.0a1 (2019-05-26)

Comment 10

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9065556 [details]
Bug 1551554 - Fix broken webextension localisation keys. r?Standard8

search regression fix, approved for 68.0b5

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2e26a62422c

Comment 12

[Rares Doghi, Desktop QA]

This issue is verified as Fixed in Beta 68.0b9 on all operating systems, I will mark this issue accordingly.