Closed Bug 1551569 Opened 5 years ago Closed 4 years ago

[Inactive CSS] Display a warning when margin or padding is set on internal table elements.

Categories

(DevTools :: Inspector: Rules, enhancement, P3)

Product:
DevTools
Component:
Inspector: Rules
Type:
enhancement

Tracking

(firefox86 fixed)

Status:
RESOLVED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: miker, Assigned: sebo)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-needed, Whiteboard: [Importance: 84.6%])

Attachments

(1 file)

Bug 1551569 - New inactive CSS rule to show warning when margin or padding is used on internal table elements. r=nchevobbe
48 bytes, text/x-phabricator-request
Details | Review

Valid for all elements except internal table elements:

[
  "margin",
  "margin-bottom",
  "margin-left",
  "margin-right",
  "margin-top",
]

Valid for all elements except: internal table elements other than table cells:

[
  "padding",
  "padding-bottom",
  "padding-left",
  "padding-right",
  "padding-top",
]
Type: defect → enhancement

Hello, I would like to work on this one, is anybody else working on it? Is it still relevant to fix this issue?

Flags: needinfo?(mratcliffe)

Sorry, I didn't notice this message.

Are you still interested in adding this?

Flags: needinfo?(mratcliffe) → needinfo?(eduar.mreyes)

Yes, I am interested in adding this, sorry I have been idle but I think I can push a fix this week.

Flags: needinfo?(eduar.mreyes)
Assignee: nobody → eduar.mreyes
Status: NEW → ASSIGNED
Priority: P2 → P3

Hi Eduar, are you still planning on addressing this bug? If you just need more time, that's totally ok. If you, however, do not intend to fix it anymore, please let me know.

Flags: needinfo?(eduar.mreyes)

Yeah, I think I will not be able to work on this for a while, to be honest.

Flags: needinfo?(eduar.mreyes)

Thanks for getting back to me so quickly. Unassigning the bug for now, it's opened to anyone who may want to fix it.

Assignee: eduar.mreyes → nobody
Status: ASSIGNED → NEW
Whiteboard: [Importance: 84.6%]
Assignee: nobody → sebastianzartner
Status: NEW → ASSIGNED
Attachment #9195977 - Attachment description: Bug 1551569 - New inactive CSS rule to show warning when margin or padding is used on internal table elements. r=miker → Bug 1551569 - New inactive CSS rule to show warning when margin or padding is used on internal table elements. r=nchevobbe
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4d2a6935eb92
New inactive CSS rule to show warning when margin or padding is used on internal table elements. r=nchevobbe,flod

https://hg.mozilla.org/mozilla-central/rev/4d2a6935eb92

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

This might be worth mentioning in the release notes for 86 together with the change in bug 1579017.

Sebastian

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: