1551588 - The "circled i" and "Dismiss" buttons from the "FxA Bookmark Panel Message" are inaccessible through keyboard navigation

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Beta 68.0b1, Build ID 20190513111358
• Firefox Nightly 68.0a1, Build ID 20190514094236

[Affected Platforms]:

• All Windows
• All Linux
• All Mac

[Prerequisites]:

• Have the "browser.newtabpage.activity-stream.asrouter.devtoolsEnabled" pref's value set to "true" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to any website and click the "Bookmark this page" button from the right part of the "Address Bar".
3. Press the "Tab" key 8 times and observe the behavior.

[Expected result]:

• The "circled i" button is focused.

[Actual result]:

• The "FxA Bookmark Panel Message" is focused.

[Notes]:

• If, after following the steps from above, the "Tab" key is pressed for one more time, the "Name" text input field is focused instead of the "X" button.
• Attached a screen recording of the issue.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1551588 - Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/089d52d6ad36
Added a tab stop to the "info" and "dismiss" buttons in the FxA Bookmark Panel Message r=k88hudson

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/089d52d6ad36

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/089d52d6ad36

Comment 5

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue and is no longer reproducible on Latest Firefox Nightly 71.0a1 (Build ID: 20190902213933) and Firefox Beta 70.0b3 (Build ID: 20190902191027) on Windows 10 x64, Mac 10.14.5 and Arch Linux 4.16.6 x64.
The "info" and "Dismiss" buttons are accessible through keyboard navigation. However, the "Dismiss" button does not have a focus effect although is selected and I logged the following issue: bug 1554739.