1551643 - Right-clicking on image to 'Copy Image' does not copy image

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Ryan Feeley [:rfeeley]]

STEPS TO REPRODUCE

1. Go to any web page with an image
2. Right-click the image
3. Select "Copy Image"
4. Paste image into another source (e.g. GitHub comment, or Slack channel)

EXPECTED RESULTS
• Image pastes

ACTUAL (AND POTENTIALLY CAREER-LIMITING) RESULTS
• Previous clipboard contents are pasted

Comment 1

[Ryan Feeley [:rfeeley]]

Appears to affect drag and drop.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

It seems to be important that there be text in the clipboard for this to reproduce. So, new STR:

1. Go to any web page with an image and some text.
2. Copy some text to the clipboard.
3. Right-click the image
4. Select "Copy Image"
5. Paste image into another source (e.g. GitHub comment, or Slack channel)

EXPECTED RESULTS
• Image pastes

ACTUAL (AND POTENTIALLY CAREER-LIMITING) RESULTS
• Previous clipboard contents are pasted

Comment 3

[Mike Conley (:mconley) (:⚙️)]

34:52.84 INFO: No more inbound revisions, bisection finished.
34:52.84 INFO: Last good revision: b081558961139b81c626b6d37055d4c60204a013
34:52.84 INFO: First bad revision: dc66462519e1960df71a10d3df05b4db2e84e279
34:52.84 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b081558961139b81c626b6d37055d4c60204a013&tochange=dc66462519e1960df71a10d3df05b4db2e84e279

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Marking tracking since this seems like something we don't want to accidentally let slip to our release channel.

Hey qDot, any idea why bug 1542415 would break clipboard actions like cut and paste, and drag and drop?

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Not a clue, off the top of my head. It's also broken cursors in some instances (Bug 1546022). This seems to just be causing all sorts of frontend pain, which is why we left it as a pref. :(

Comment 6

[Andrew Overholt [:overholt]]

(Just in case you're looking here and haven't seen it, there's talk of flipping the pref in https://bugzilla.mozilla.org/show_bug.cgi?id=1542415#c19)

Comment 7

[Julien Cristau [:jcristau]]

The pref change was backed out in bug 1551993.

Comment 8

[Drew Willcoxon :adw]

So per comment 7, this was fixed by bug 1551993, right? Can we close this?

Comment 9

[Justin Dolske [:Dolske]]

SGTM.

Comment 10

[petersonazv]

So I still have this bug in Firefox Developer Edititon 73.0b3 (64-bits)

Comment 11

[rasmusbeck2k]

Also experiencing this, Firefox 73.0b3 64-bit on Windows 10 64-bit. Started happening a few days ago.

Comment 12

[Zulith]

Definitely still present in 73b3. On some sites the images copy fine, others not. Google Images and IMDB are two sites impacted.

Comment 13

[Julien Cristau [:jcristau]]

Please file a new bug for the issue in 73.

Comment 14

[dbcongard]

ArchLinux, Firefox 72.0.2 the same issue. Drag & drop works without any issues.