Closed Bug 1551812 Opened 4 months ago Closed 4 months ago

[Inactive CSS] Display a warning when `vertical-align` is used incorrectly

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

enhancement

Tracking

(firefox69 verified)

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: pbro, Assigned: pbro)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Importance: 81.8%])

Attachments

(1 file)

vertical-align only applies to inline and table-cell elements: you can't use it to vertically align block-level elements.

Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce28e766055d
New InactiveCSS rule for vertical-align; r=flod
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

(In reply to Patrick Brosset <:pbro> from comment #0)

vertical-align only applies to inline and table-cell elements: you can't use it to vertically align block-level elements.

Not really!
vertical-align applies at least to display types like inline-block inline-table
and
table-row table-row-group table-header-group table-footer-group
<tr> <tbody> <thead> <tfoot> (cells default is vertical-align:inherit)
https://dxr.mozilla.org/mozilla-central/source/layout/style/res/html.css#438

Flags: needinfo?(pbrosset)

Thank you, I filed bug 1554723 for this.

Flags: needinfo?(pbrosset)

Verified in junction with 1554723 using 69.0b4.

Status: RESOLVED → VERIFIED
Whiteboard: [Importance: 81.8%]
You need to log in before you can comment on or make changes to this bug.