1554723 - [Inactive CSS] Make the `vertical-align` warning appear correctly

Status: VERIFIED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Patrick Brosset <:pbro>]

In bug 1551812 I added an InactiveCSS warning for misuse of vertical-align. Turns out the way this was done isn't totally correct.
See bug 1551812 comment 4:

vertical-align applies at least to display types like inline-block inline-table and table-row table-row-group table-header-group table-footer-group <tr> <tbody> <thead> <tfoot> (cells default is vertical-align:inherit)

So we should fix it.

Comment 1

[Patrick Brosset <:pbro>]

Here's an example of it working for inline-flex and inline-grid actually:

data:text/html,<style>.one {display:inline-flex} .two {display:inline-grid;vertical-align:sub;}</style><div class="one">one</div><div class="two">two</div>

Comment 2

[Patrick Brosset <:pbro>]

Attachment: Bug 1554723 - Correctly exclude all inline-level elements when warning for misuse of vertical-align r?miker!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/346ed53489fc
Correctly exclude all inline-level elements when warning for misuse of vertical-align r=miker

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/346ed53489fc

Comment 5

[Cristian Fogel [:cfogel]]

Confirmed the issue with 68.0a1 (2019-05-15).

Adjusted the TC to confirm the inline-flex part as well:
data:text/html,<style>.one {display:inline-flex; vertical-align:sub;} .two {display:inline-grid;vertical-align:sub;}</style><div class="one">one</div><div class="two">two</div>

Fix confirmed with 69.0b3.