Closed Bug 1551844 Opened 7 months ago Closed 6 months ago

Implement NEON support for qcms

Categories

(Core :: GFX: Color Management, enhancement, P3)

ARM64
Windows 10
enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(1 file)

Windows performs color management by default, and on ARM devices, we use the fallback C implementation.

Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Type: defect → enhancement
Depends on: 1551084
OS: Unspecified → Windows 10
Priority: -- → P3
Hardware: Unspecified → ARM64
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/331846de4391
Implement NEON variations of QCMS ICCv2 transforms. r=lsalzman
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/c8c648d14cb8
Backed out changeset 331846de4391 for ccwn2c08.html and ccwn3p08.html failures a=backout

Backed out changeset 331846de4391 (Bug 1551844) for ccwn2c08.html and ccwn3p08.html failures
https://hg.mozilla.org/mozilla-central/rev/c8c648d14cb8

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Reason for backout:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=android%2C4.3%2Capi16%2B%2Copt%2Creftests%2Cwithout%2Ce10s%2Ctest-android-em-4.3-arm7-api-16%2Fopt-reftest-1proc-1%2Cr-1proc%28r1%29&tochange=2c2fb7f47cc90c1698d03c6dba270df691bbecde&fromchange=62f14c80b305c694b4758c83c39d722d7682c0db&selectedJob=251849908

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=android%2C4.3%2Capi16%2B%2Cpgo%2Creftests%2Cwithout%2Ce10s%2Ctest-android-em-4.3-arm7-api-16%2Fpgo-reftest-1proc-1%2Cr-1proc%28r1%29&tochange=2c2fb7f47cc90c1698d03c6dba270df691bbecde&fromchange=62f14c80b305c694b4758c83c39d722d7682c0db&selectedJob=251850615

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=android%2C4.3%2Capi16%2B%2Cdebug%2Creftests%2Cwithout%2Ce10s%2Ctest-android-em-4.3-arm7-api-16%2Fdebug-reftest-1proc-1%2Cr-1proc%28r1%29&selectedJob=251850797

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251849908&repo=mozilla-inbound&lineNumber=2213

[task 2019-06-14T08:41:37.043Z] 08:41:37 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.png == http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.html
[task 2019-06-14T08:41:37.044Z] 08:41:37 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.png | 167 / 554 (30%)
[task 2019-06-14T08:41:37.046Z] 08:41:37 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.html | 167 / 554 (30%)
[task 2019-06-14T08:41:47.764Z] 08:41:47 INFO - REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.png == http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.html | image comparison, max difference: 1, number of differing pixels: 6
[task 2019-06-14T08:41:47.841Z] 08:41:47 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5q...
[task 2019-06-14T08:41:47.921Z] 08:41:47 INFO - REFTEST IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAgAElEQV....
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.png
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.html
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.png == http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn2c08.html
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST TEST-START | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.png == http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.html
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.png | 168 / 554 (30%)
[task 2019-06-14T08:41:47.927Z] 08:41:47 INFO - REFTEST TEST-LOAD | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.html | 168 / 554 (30%)
[task 2019-06-14T08:41:58.805Z] 08:41:58 INFO - REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.png == http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.html | image comparison, max difference: 1, number of differing pixels: 19
[task 2019-06-14T08:41:58.879Z] 08:41:58 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAgAElEQVR4nOy9UZIsx5EsW...
[task 2019-06-14T08:41:58.959Z] 08:41:58 INFO - REFTEST IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAgAElEQVR4nOy9UZI...
[task 2019-06-14T08:41:58.964Z] 08:41:58 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.png
[task 2019-06-14T08:41:58.964Z] 08:41:58 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-06-14T08:41:58.964Z] 08:41:58 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-06-14T08:41:58.965Z] 08:41:58 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: START http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.html
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-06-14T08:41:58.966Z] 08:41:58 INFO - REFTEST TEST-END | http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.png == http://10.0.2.2:8854/tests/image/test/reftest/pngsuite-ancillary/ccwn3p08.html

Flags: needinfo?(aosmond)

Just needs some fuzz for these two cases, will reland with it.

Flags: needinfo?(aosmond)
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00bc27f8de03
Implement NEON variations of QCMS ICCv2 transforms. r=lsalzman
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.