Add BGRA support to qcms
Categories
(Core :: Graphics: Color Management, enhancement, P3)
Tracking
()
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(5 files)
The image decoders output with BGRA. It would be good if QCMS could deal with said format, permitting us to color manage at the end of a pipeline (e.g. after downscaling) rather than at the start.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
No functional change. This allows us to support both alpha and non-alpha
variants with the same implementation, in addition to laying the ground
work for QCMS to support BGRA as an input and output.
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cd1bb23b475a Part 1. Minor reworking of QCMS to allow C files to compile as C++. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/d73949bd98e9 Part 2. Make QCMS transform files use C++. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/99874bf89419 Part 3. Use templates to reduce code duplication in QCMS. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/2a5ae3eb40ce Part 4. Add support for BGRA to QCMS. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/af04f8907fab Part 5. Allow QCMS gray transforms to expand to add alpha. r=miko
Comment 7•5 years ago
|
||
Backed out for build bustages on transform.cpp
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/1e50992f413317d69190830a556daea79d98fed3
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=248561705&repo=mozilla-inbound&lineNumber=17268
Assignee | ||
Comment 8•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ce491ef456b714b4a636b2200080a25201fd572
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e198d4820748 Part 1. Minor reworking of QCMS to allow C files to compile as C++. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/d3d79df02bf6 Part 2. Make QCMS transform files use C++. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/34a34996c412 Part 3. Use templates to reduce code duplication in QCMS. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/f9dc8aad0d4f Part 4. Add support for BGRA to QCMS. r=miko https://hg.mozilla.org/integration/mozilla-inbound/rev/04977d948042 Part 5. Allow QCMS gray transforms to expand to add alpha. r=miko
Comment 10•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e198d4820748
https://hg.mozilla.org/mozilla-central/rev/d3d79df02bf6
https://hg.mozilla.org/mozilla-central/rev/34a34996c412
https://hg.mozilla.org/mozilla-central/rev/f9dc8aad0d4f
https://hg.mozilla.org/mozilla-central/rev/04977d948042
Updated•5 years ago
|
Description
•