Closed Bug 1551084 Opened 6 months ago Closed 6 months ago

Add BGRA support to qcms

Categories

(Core :: GFX: Color Management, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

References

Details

Attachments

(5 files)

The image decoders output with BGRA. It would be good if QCMS could deal with said format, permitting us to color manage at the end of a pipeline (e.g. after downscaling) rather than at the start.

Assignee: nobody → aosmond
Blocks: 1255106
Status: NEW → ASSIGNED
Priority: -- → P3

No functional change. This allows us to support both alpha and non-alpha
variants with the same implementation, in addition to laying the ground
work for QCMS to support BGRA as an input and output.

Blocks: 1551844
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd1bb23b475a
Part 1. Minor reworking of QCMS to allow C files to compile as C++. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/d73949bd98e9
Part 2. Make QCMS transform files use C++. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/99874bf89419
Part 3. Use templates to reduce code duplication in QCMS. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a5ae3eb40ce
Part 4. Add support for BGRA to QCMS. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/af04f8907fab
Part 5. Allow QCMS gray transforms to expand to add alpha. r=miko
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e198d4820748
Part 1. Minor reworking of QCMS to allow C files to compile as C++. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3d79df02bf6
Part 2. Make QCMS transform files use C++. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/34a34996c412
Part 3. Use templates to reduce code duplication in QCMS. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9dc8aad0d4f
Part 4. Add support for BGRA to QCMS. r=miko
https://hg.mozilla.org/integration/mozilla-inbound/rev/04977d948042
Part 5. Allow QCMS gray transforms to expand to add alpha. r=miko
Regressions: 1555329
You need to log in before you can comment on or make changes to this bug.