1551849 - [socket process] onLookupComplete - [onLookupComplete : 17] 2152398864 == 0, test_dns_offline.js

Status: RESOLVED DUPLICATE of bug 1559865

(Core :: Networking: DNS, defect, P2)

Description

[Kershaw Chang [:kershaw]]

Why this test failure:
At [1], we expect the status to be NS_OK, but the status is NS_ERROR_OFFLINE.

Steps that caused this failure:

1. We use ChildDNSService on parent process to do DNS resolution.
2. At [2], we set flag to RESOLVE_OFFLINE.
3. On socket process, we check the offline flag again at [3].
4. The flag should not be set to RESOLVE_OFFLINE since the test set network.dns.offline-localhost to true.
5. ResolveHost still returns NS_ERROR_OFFLINE since the flag is already set to RESOLVE_OFFLINE at step 2.

[1] https://searchfox.org/mozilla-central/rev/116bd975c30746ddefc3d20e6947d1871469354f/netwerk/test/unit/test_dns_offline.js#17
[2] https://searchfox.org/mozilla-central/rev/116bd975c30746ddefc3d20e6947d1871469354f/netwerk/dns/ChildDNSService.cpp#82
[3] https://searchfox.org/mozilla-central/rev/116bd975c30746ddefc3d20e6947d1871469354f/netwerk/dns/nsDNSService2.cpp#824-827
[4] https://searchfox.org/mozilla-central/rev/116bd975c30746ddefc3d20e6947d1871469354f/netwerk/test/unit/test_dns_offline.js#52

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1551849 - Don't set offline flag if DNS resolution is done in socket process