1552039 - Inline breakpoints retained while file changed

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[:Harald Kirschner :digitarald]

Attachment: image.png

What were you doing?

1. I set a breakpoint in the render function in https://firefox-devtools-example-babel-typescript.glitch.me/
2. Edited the JSX and broke it down into multiple lines
3. Refreshed the page

What happened?

Breakpoints spilled all over the old line.

What should have happened?

Remove invalid columns, as the old ones don't apply at all.

Anything else we should know?

I have not tried reproducing it, just filing to have it captured. STR might be faulty.

Comment 1

[Jason Laster [:jlast]]

I think this is a dupe of bug 1533547. I'll look a bit more soon.

Comment 2

[Jason Laster [:jlast]]

This is a bug with sourcemaps, we should likely file this bug against babel's jsx plugin.

CC Logan, do you know the right place to report this bug?

https://babeljs.io/repl#?babili=false&browsers=&build=&builtIns=false&spec=false&loose=false&code_lz=GYVwdgxgLglg9mABMOdEAoCUiDeAoRRAJwFMoQikAeAExgDcDDmEBhAGxggGsBeHLIl4A-RBAQBnOOxIA6dnADm6AOQALGCswBfJs0LC9iAExGqAejr1DuwkA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=true&fileSize=false&timeTravel=false&sourceType=script&lineWrap=true&presets=es2015%2Creact%2Cstage-2&prettier=false&targets=&version=7.4.5&externalPlugins=

Comment 3

[Jason Laster [:jlast]]

Hmm, here it is in a repl w/ source maps

https://deploy-preview-1655--babel.netlify.com/repl#?babili=false&browsers=&build=&builtIns=false&spec=false&loose=false&code_lz=FAYwNghgzlAEAesDetbAGYHtOwBQEplhUAnAUwBcBXEgO1gB4AHNVN99zWgYTAEsQAawC8SXGQBuFQsIB8sCgAs-UAHRYSIMgBUBg8VPwBfYhzOxZ2xWVgga5WhQV8AtjZXIwmEBDA7XZCbsDAD0TLKmJkGwQA&debug=false&forceAllTransforms=false&shippedProposals=false&circleciRepo=&evaluate=false&fileSize=false&timeTravel=false&sourceType=module&lineWrap=true&presets=es2015%2Creact%2Cstage-2&prettier=false&targets=&version=6.26.0&envVersion=

This is not exactly what i expected as the function expression/calls were mapped correctly. Thoughts?

Comment 4

[Jason Laster [:jlast]]

okay, after looking into it this feels like an issue with webpack.

1. babel's maps look good in the link above
2. the breakpoint positions in the generated code look good
3. my guess is the minifier mangled the locations

Comment 5

[Jason Laster [:jlast]]

Attachment: mappings.jpg

Comment 6

[Jason Laster [:jlast]]

Chrome has a similar issue, but they do not show inline breakpoints that are out of range on the line. That sounds like a reasonable option here because they certainly are confusing.

Comment 7

[Jason Laster [:jlast]]

Attachment: Screen Shot 2019-05-29 at 9.37.42 AM.png

Comment 8

[Jason Laster [:jlast]]

Attachment: Bug 1552039 - filter breakpoints to the right of the line. r=davidwalsh

Comment 9

[Jason Laster [:jlast]]

Attachment: Screen Shot 2019-05-29 at 10.04.18 AM.png

Comment 10

[Jason Laster [:jlast]]

This is what it looks like after the fix.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/865ab825ed58
filter breakpoints to the right of the line. r=davidwalsh

Comment 12

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/865ab825ed58