1533547 - Column Breakpoints are not visible when reloading

Status: RESOLVED WONTFIX

(DevTools :: Debugger, task, P1)

Description

[Jason Laster [:jlast]]

STR

1. go to dbg-scratchpad.glitch.me and add some column bps
2. go to https://glitch.com/edit/#!/dbg-scratchpad?path=public/client.js:8:0 and edit client.js
3. reload

ER: see column breakpoints
AR: don't see column breakpoints

Comment 1

[Jason Laster [:jlast]]

The problem here was that we were not updating the viewport.

Comment 2

[Jason Laster [:jlast]]

This was fixed

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can still reproduce the problem on my machine.

Here is my STR:

1. Load https://glitch.com/edit/#!/dbg-scratchpad?path=public/client.js:8:0
2. Click 'Remix to Edit'
3. Click 'Show' -> In a new window
4. Select the new tab and open Debugger on it
5. Select 'client.js' and create Col BP on line console.log('stuff')
6. Go back to the previous tab, edit the client.js file. You can see how the other tab is auto reloading.
7. Switch back to the other tab. The BP is gone -> BUG
   Reload and the BP is back.

@Jason, can you reproduce that?

Honza

Comment 4

[Jason Laster [:jlast]]

Thanks, yes I can.

Comment 5

[Jason Laster [:jlast]]

Attachment: reload.gif

Comment 6

[Jason Laster [:jlast]]

Honza, I looked into it today and it worked as expected. i.e. when there was a breakpoint position that matched a breakpoint the breakpoint was shown in the UI.

Could you re-test and let me know what you think?

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can still reproduce that.

Try to append a new line e.g. in the function a() 5; so console.log('stuff') moves to the next line.

Honza

Comment 8

[Jason Laster [:jlast]]

This looks like a breakpoint syncing edge case with glitch's hot reloading system. We can re-open if we find a more common case.