1552061 - Switching files resets currently focused location

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[:Harald Kirschner :digitarald]

What were you doing?

1. Open a source #a in debugger and scroll down and to the right, setting a cursor somewhere in a longer line.
2. Open another source #b.
3. Navigate back to source #a

Alternative

3. Pause in source #a
4. Switch from #b to #a

What happened?

Source #a always opens scrolled to the top.

When paused the first line in source #a gets an animation highlight for no reason.

What should have happened?

Remember the current scroll and cursor position.

Comment 1

[Jason Laster [:jlast]]

I believe this is similar to https://github.com/firefox-devtools/debugger/issues/7951

[Tabs] selecting a tab should return to the prior location #7951

Comment 2

[Dhyey Thakore [:dhyey35]]

I and David proposed a couple of solutions but David said they weren't elegant enough.

My PR: https://github.com/firefox-devtools/debugger/pull/8076
David's PR: https://github.com/firefox-devtools/debugger/pull/8102

Can you recommend a better approach ?

Comment 3

[Jason Laster [:jlast]]

Sorry Dhyey, it's been awhile and I've forgotten. I think my thinking was we should be able to have a field selectedSource in the reducer that we set if that is you select a tab. At that point the editor would update, but we would not try and scroll.

Comment 4

[David Walsh :davidwalsh]

Attachment: Bug 1552061 - Keep scrolling location for individual documents r=jlast

Ensures scroll position stays the same between tab switches while paused and not paused.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f96077d464a
Keep scrolling location for individual documents r=jlast

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8f96077d464a