1552279 - FindBarChild should become an allFrames singleton

Status: RESOLVED DUPLICATE of bug 1553384

(Toolkit :: Find Toolbar, enhancement, P3)

Description

[Brad Werth [:bradwerth]]

Bug 1322385 made a change so FastFind no longer attempts to handle events triggered from within a mozbrowser iframe, since mozbrowser iframes have their own instance of the FindBarChild Actor and can handle it directly. This change could have been optimized further by making the FindBarChild a singleton Actor (with allFrames: true). This was attempted as part of Bug 1322385, but that led to problems with the Actor no longer being attached to frames needed for the test toolkit/content/tests/chrome/test_findbar_entireword.xul

This change should be made to make FindBarChild more correct and memory efficient when we move to one-process-per-domain.

Some analysis at https://bugzilla.mozilla.org/show_bug.cgi?id=1322385#c31

Comment 1

[Neil Deakin]

Is this bug still relevant given the changes in bug 1553384?

Comment 2

[Brad Werth [:bradwerth]]

(In reply to Neil Deakin from comment #1)

Is this bug still relevant given the changes in bug 1553384?

Bug 1553384 made FindBarChild an allFrames: true singleton. This is resolved.