1553384 - Make 'Find in page' work in fission world

Status: RESOLVED FIXED

(Core :: Find Backend, defect, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

nsWebBrowserFind.cpp and nsTypeAheadFind.cpp enumerate nsDocShellTreeItems, we need to replace it with using BrowsingContext (bug 1467214). We also need to make 'scrolling to a given frame rect' in fission (bug 1553012). I am not sure whether there are more tasks needed for fission.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

CCing Mike de Boer and Brad Werth since he had touched those code.

Comment 2

[Neil Deakin]

I moved the WebBrowserFind parts to bug 1570965.

Comment 3

[Neil Deakin]

Attachment: Bug 1553384, add a separate method to typeahead find that allows searching only within a single frame. A mode argument is used instead of separate find/findAgain methods that can be used with different values on each child frame in sequence to...

...search through a set of frames, r?mikedeboer

Comment 4

[Neil Deakin]

Attachment: Bug 1553384, add a search subframes flag to the finder to opt in or out of subframe searching, r=mikedeboer

Comment 5

[Neil Deakin]

Attachment: Bug 1553384, when not searching subframes, used for out-of-process subframes, disable modal highlighting, r=mikedeboer

Depends on D41218

Comment 6

[Neil Deakin]

Attachment: Bug 1553384, disable the modal highlight color when fission is enabled, r=mikedeboer

Depends on D41220

Comment 7

[Neil Deakin]

Attachment: Bug 1553384, when subframe iteration is not used, don't navigate up to the top window in the find highligher. However, as fission doesn't handle getting frame coordinates yet, allow some callers to get the top window anyway if available so that...

...coordinates are correct when fission is disabled, r?mikedeboer

Depends on D41221

Comment 8

[Neil Deakin]

Attachment: Bug 1553384, find should iterate over each frame within a document in the parent process to allow out-of-process frames to be searched through, r=mikedeboer

Depends on D41222

Comment 9

[Neil Deakin]

Attachment: Bug 1553384, update findbar actors to inherit from JSWindowActor so that type ahead find works in out of process iframes, r=mikedeboer

Depends on D41224

Comment 10

[Neil Deakin]

Attachment: Bug 1553384, update find extension api to support out-of-process iframes. r=mixedpuppy

Depends on D41226

Comment 11

[Neil Deakin]

Attachment: Bug 1553384, remove old find/findAgain methods in typeaheadfind in favour of a single find method, r=mikedeboer

Depends on D41229

Comment 12

[Neil Deakin]

Two things still to do here:

1. Fix up the RDFHelperChild.jsm (used for resist fingerprinting) as is detects findbar open/close messages
2. The changes from tabbrowser.js to handle uninitialized findbar -- need to investigate what if anything needs to be done here

Comment 13

[Neil Deakin]

Attachment: Bug 1553384, update letterboxing to be fission compatible now that findbar isn't using the message manager. Add a findbar open/close test for letterboxing, r=tjr,mconley

Comment 14

[Neil Deakin]

Attachment: Bug 1553384, fix intermittent orange caused by fission changes, by waiting for page and findbar to be ready

Comment 15

[Neil Deakin]

I landed this with an additional fix which I think will fix an intermittent orange I found at the last minute.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28490e71adab
add a separate method to typeahead find that allows searching only within a single frame. A mode argument is used instead of separate find/findAgain methods that can be used with different values on each child frame in sequence to... r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/2e7108b6bfc2
add a search subframes flag to the finder to opt in or out of subframe searching, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/771094a651ca
when not searching subframes, used for out-of-process subframes, disable modal highlighting, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/76e59e4beb07
disable the modal highlight color when fission is enabled, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/2c1d142dbc8a
when subframe iteration is not used, don't navigate up to the top window in the find highligher. However, as fission doesn't handle getting frame coordinates yet, allow some callers to get the top window anyway if available so that... r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/ea3cbf08fa69
find should iterate over each frame within a document in the parent process to allow out-of-process frames to be searched through, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/46f35eae82f6
update findbar actors to inherit from JSWindowActor so that type ahead find works in out of process iframes, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/3977d67dc67a
update find extension api to support out-of-process iframes. r=mixedpuppy
https://hg.mozilla.org/integration/autoland/rev/21aa59810375
remove old find/findAgain methods in typeaheadfind in favour of a single find method, r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/656e05faba49
update letterboxing to be fission compatible now that findbar isn't using the message manager. Add a findbar open/close test for letterboxing, r=mconley
https://hg.mozilla.org/integration/autoland/rev/e33c3e14ee40
fix intermittent orange caused by fission changes, by waiting for page and findbar to be ready

Comment 17

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/28490e71adab
https://hg.mozilla.org/mozilla-central/rev/2e7108b6bfc2
https://hg.mozilla.org/mozilla-central/rev/771094a651ca
https://hg.mozilla.org/mozilla-central/rev/76e59e4beb07
https://hg.mozilla.org/mozilla-central/rev/2c1d142dbc8a
https://hg.mozilla.org/mozilla-central/rev/ea3cbf08fa69
https://hg.mozilla.org/mozilla-central/rev/46f35eae82f6
https://hg.mozilla.org/mozilla-central/rev/3977d67dc67a
https://hg.mozilla.org/mozilla-central/rev/21aa59810375
https://hg.mozilla.org/mozilla-central/rev/656e05faba49
https://hg.mozilla.org/mozilla-central/rev/e33c3e14ee40