1552371 - add an indication/warning when a soft code freeze is in place

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement, P2)

Description

[Cameron McCormack (:heycam)]

There is a soft freeze on now, but I see an awful lot of code landing and I wonder whether people are aware of the soft freeze or making the right judgement about whether the landing should wait. If we have a check box to click through on Lando when there is a soft freeze on, it might help prompt people to consider whether their code should land right now.

Comment 1

[:glob ✱]

this is probably a duplicate of bug 1437614.

edit: probably not

Comment 2

[:glob ✱]

this is blocked by a programmatic way to determine if a given tree is currently in a soft freeze; i'm not sure anymore if this is part of the tree status api. i've asked the sheriffs.

Comment 3

[:glob ✱]

unfortunately there's nothing currently available which could be consumed by lando to determine if there's a soft freeze currently in place.

Comment 4

[James Teh [:Jamie]]

I mistakenly landed a stack of 18 patches during soft code freeze recently. This was after a backout, so when I re-landed a few days later, it didn't occur to me to consider whether code freeze might have begun in the interim. Thankfully, no harm was done. While it's fair to argue I should've been more careful, it really would be helpful if Lando could flag this. I understand the technical limitation here (comment 3), but could there be some simple calendar somewhere that an API could consume?

Comment 5

[Julien Cristau [:jcristau]]

Could lando check NEXT_SOFTFREEZE_DATE in https://product-details.mozilla.org/1.0/firefox_versions.json and display something for rMOZILLACENTRAL patches if it's in the past?

Comment 6

[Julien Cristau [:jcristau]]

(or maybe "if NEXT_SOFTFREEZE_DATE is in the past and NEXT_MERGE_DATE is in the future" is more accurate)

Comment 7

[Paul Adenot (:padenot)]

It would be ideal if this would be fixed, I just did precisely the same thing as James with an enormous patch set I was relanding, thankfully it was noticed, I got notified and I was able to get it backed out quickly.

Comment 8

[:glob ✱]

(In reply to Julien Cristau [:jcristau] from comment #5)

Could lando check NEXT_SOFTFREEZE_DATE in https://product-details.mozilla.org/1.0/firefox_versions.json and display something for rMOZILLACENTRAL patches if it's in the past?

Great, thanks - pretty sure that information wasn't there last time I checked product-details.

This is already on the radar with the goal of pulling from fx-trains, but that's blocked by a production deployment of that product. Glad that the information is available elsewhere. I'll chat with the team.

Do you know who owns product-details? It would be nice to expose the string-freeze date.

Comment 9

[Graham Robertson [:grammar]]

Attachment: Bug 1552371 - add firefox_versions.json to test repo for dev testing r?zeid

Comment 10

[:glob ✱]

Looks like this landed but the bug was never updated: https://github.com/mozilla-conduit/lando-api/commit/39872a1a065e7fc63d6d349c54dc16174897a2a9