1552780 - Abuse report panel should have a semi-transparent grey background

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco] (PTO -> Jan 7 2026)]

In Bug 1551202 have been applied changes to the abuse report panel and HTML about:addons CSS rules to improve their "dark theme" look.

One of the changes applied is related to the "abuse report panel"'s .modal-overlay-outer element, changed from background: rgba(12, 12, 13, 0.6); to background: var(--grey-90-a60);.

Unfortunately the --grey-90-a60 CSS variable doesn't seem to be part of the grey colors defined in common.inc.css and so the modal background color have been regressed in Bug 1551202 (in particular by the changes applied in 2519b62544) and it is not currently being set (because the variable referenced does not exist).

Comment 1

[Rob Wu [:robwu]]

Surprisingly, this was not caught by browser/base/content/test/static/browser_parsable_css.js. Possibly because the test evaluates all style sheets at once, and the variable is defined in devtools/client/aboutdebugging-new/src/base.css.

We should add the color definition after https://searchfox.org/mozilla-central/rev/f4c39907e0b527dc4b9356a1eeb8c6e6c62d383a/toolkit/themes/shared/in-content/common.inc.css#74

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1552780 - Add missing --grey-90-a60 variable

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5656f335316
Add missing --grey-90-a60 variable r=jaws

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b5656f335316

Comment 5

[Julien Cristau [:jcristau]]

Please request beta uplift when you get a chance.

Comment 6

[Rob Wu [:robwu]]

Comment on attachment 9066678 [details]
Bug 1552780 - Add missing --grey-90-a60 variable

Beta/Release Uplift Approval Request

• User impact if declined: When extensions.abuseReport.enabled and extensions.htmlaboutaddons.enabled are true, the background of the Report Abuse panel is not clearly distinguishable.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple one-line change for a new feature in Fx68 - bug 1543377
• String changes made/needed: none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9066678 [details]
Bug 1552780 - Add missing --grey-90-a60 variable

add missing color to css, approved for 68.0b6

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/92ad83577764

Comment 9

[CosminB]

Attachment: Bug1552780.png

I can reproduce this issue on Firefox 69.0a1 (20190524214959) under Wind 7 64-bit.

This issue is verified as fixed on Firefox 69.0a1 (20190529215251) and 68.0b6 (20190529145824) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.