Open Bug 1553182 Opened 6 years ago Updated 2 years ago

Profiler popup does not have UI feedback when shortcut hit and it is hidden

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect

Tracking

(Not tracked)

People

(Reporter: gregtatum, Unassigned)

References

(Blocks 1 open bug)

Details

Once Bug 1307227, it will integrate the Gecko Profiler Add-on directly into Firefox. There is an existing issue with the web extension, where when you hit the shortcut, and the button is not visible in the toolbar, then there is no feedback given to the user that the profiler is active. :jdescottes had the suggestion to only use the shortcut work when the button is visible. Alternately we could manually move the button location when the shortcut is pressed so that it is in view.

Steps to reproduce:

  • Enable the profiler menu button
  • Right click button, choose customize
  • Drag the profiler button off the toolbar
  • Exit out
  • Hit Ctrl-Shift-1

Expected results:

  • The user can visually see that the browser is being profiled.

Actual results:

  • There is no indication of anything changing.
Depends on: 1307227
Priority: -- → P3
Blocks: 1566920
Component: Gecko Profiler → Performance Tools (Profiler/Timeline)
Product: Core → DevTools
Version: 62 Branch → Trunk
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.