Closed Bug 1553210 Opened 5 months ago Closed Last month

"Remove All Breakpoints" should clear pending breakpoints

Categories

(DevTools :: Debugger, enhancement, P2)

enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jlast, Assigned: obulat)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 2 obsolete files)

When the user selects "Remove All Breakpoints" it should wipe all of the save breakpoints. This will make it easy for users to stop seeing phantom breakpoints.

Priority: -- → P2
 export function removeAllBreakpoints(cx: Context) {
   return async ({ dispatch, getState }: ThunkArgs) => {
     const breakpointList = getBreakpointsList(getState());
-    return Promise.all(
+    await Promise.all(
       breakpointList.map(bp => dispatch(removeBreakpoint(cx, bp)))
     );
+
+    // I think we should also clear all the pending breakpoints as well.
   };
Keywords: good-first-bug

I would like to try tackle this.
Would something like this work?

const breakpointList = getBreakpointsList(getState()).concat(getPendingBreakpointList(getState()));
    return Promise.all(
      breakpointList.map(bp => dispatch(removeBreakpoint(cx, bp)))
    );
Flags: needinfo?(jlaster)

hmm, i'm not sure what the best way to clear the pending breakpoint list. but either way, it is yours :)

Flags: needinfo?(jlaster)
Assignee: nobody → obulat

Add action for clearing pending breakpoints

Attachment #9071093 - Attachment description: Address revision issues: add tests → Bug 1553210 - Implement clearing pending breakpoints and add tests. r=jlast
Attachment #9068289 - Attachment is obsolete: true
Attachment #9072426 - Attachment is obsolete: true
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d506ae7fd6b
Implement clearing pending breakpoints and add tests. r=davidwalsh
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Regressions: 1579576
Regressions: 1565459
Regressions: 1492954
You need to log in before you can comment on or make changes to this bug.