1553210 - "Remove All Breakpoints" should clear pending breakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P2)

Description

[Jason Laster [:jlast]]

When the user selects "Remove All Breakpoints" it should wipe all of the save breakpoints. This will make it easy for users to stop seeing phantom breakpoints.

Comment 1

[Jason Laster [:jlast]]

 export function removeAllBreakpoints(cx: Context) {
   return async ({ dispatch, getState }: ThunkArgs) => {
     const breakpointList = getBreakpointsList(getState());
-    return Promise.all(
+    await Promise.all(
       breakpointList.map(bp => dispatch(removeBreakpoint(cx, bp)))
     );
+
+    // I think we should also clear all the pending breakpoints as well.
   };

Comment 2

[Olga Bulat]

I would like to try tackle this.
Would something like this work?

const breakpointList = getBreakpointsList(getState()).concat(getPendingBreakpointList(getState()));
    return Promise.all(
      breakpointList.map(bp => dispatch(removeBreakpoint(cx, bp)))
    );

Comment 3

[Jason Laster [:jlast]]

hmm, i'm not sure what the best way to clear the pending breakpoint list. but either way, it is yours :)

Comment 4

[Olga Bulat]

Attachment: Bug 1553210 - Implement clearing pending breakpoints. r=jlast

Add action for clearing pending breakpoints

Comment 5

[Olga Bulat]

Attachment: Bug 1553210 - Implement clearing pending breakpoints and add tests. r=jlast

Comment 6

[Olga Bulat]

Attachment: Bug 1553210 - Address revision issues: Test for pending breakpoints; remove separate action. r=jlast

Comment 7

[Jason Laster [:jlast]]

Attachment: Bug 1553210 - Implement clearing pending breakpoints and add tests. r=davidwalsh

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d506ae7fd6b
Implement clearing pending breakpoints and add tests. r=davidwalsh

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1d506ae7fd6b