Closed Bug 1553302 Opened 5 months ago Closed 5 months ago

Turn off jittest on android-hw-8.0-aarch64, instead run SM(p) on integration branches

Categories

(Testing :: General, task, P3)

task

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: egao, Assigned: egao)

References

Details

Attachments

(1 file)

Due to bug #1552051 landing on mozilla-central which turns on jittest for windows10-aarch64, it can now safely be turned off for android 8.0 on the aarch64 platform.

:cpeterson - now that bug 1552051 patch has landed and SM(p) is being run on windows10-aarch64/opt, I would like to confirm the following:

  • jittest to be turned off on all android-hw-8-0 (this bug);
  • jsreftest is to be added to android-p2/arm7 and disabled on android-em-4.3 (new bug)
Flags: needinfo?(cpeterson)
Type: defect → task

To make sure we are all on the same page, let's note that android 8.0 aarch64 jittest currently runs on integration branches + mozilla-central, while windows10-aarch64 SM(p) only runs on mozilla-central. Do we need windows10-aarch64 SM(p) to run on integration branches too? If so, do we need that before turning off android 8.0 aarch64 jittest?

:gbrown - that's a good point, I believe jmaher stated that the plan is to move entirely to windows10-aarch64 for running JS tests, so my guess is that we would need to have SM(p) run on integration branches as well.

(In reply to Edwin Gao (:egao) from comment #1)

:cpeterson - now that bug 1552051 patch has landed and SM(p) is being run on windows10-aarch64/opt, I would like to confirm the following:

  • jittest to be turned off on all android-hw-8-0 (this bug);
  • jsreftest is to be added to android-p2/arm7 and disabled on android-em-4.3 (new bug)

My understanding was that we intended to turn off jsreftests and jittests on Android devices and instead rely on the ARM64 Windows laptops for our ARM64 testing? Like you said in comment 3: "I believe jmaher stated that the plan is to move entirely to windows10-aarch64 for running JS tests".

Flags: needinfo?(cpeterson)
See Also: → 1553310

:jmaher - there appears to be some confusion around JS tests on windows10-aarch64 and android platforms.

My understanding is to disable jittest for android and move to windows10-aarch64. jsreftest is considered separate and for that we are to run it on the android hardware platform instead of android-4.3 emulator.

Is my understanding correct?

Flags: needinfo?(jmaher)

I was under the impression the final goal was:

  • aarch64 - windows
  • arm7 - android/p2
  • no other android jittest/jsreftest

If we should be running sm(p) per commit, that would make sense- it should be on schedules so that it is only run when JS code is changed.

Flags: needinfo?(jmaher)

OK, so let's break this down as:

  • run windows10-aarch64 SM(p) on integration branches
  • turn off android-hw aarch64 jittest
  • turn on android-hw arm7 jittest
  • turn on android-hw arm7 jsreftest
  • turn off android-em jsreftests (4.3 and 7.0)

:gbrown, :jmaher - thanks for the clarification, will proceed as :gbrown has written in comment #7.

(In reply to Geoff Brown [:gbrown] from comment #7)

  • turn on android-hw arm7 jittest
  • turn on android-hw arm7 jsreftest

SGTM. I missed that we will be testing arm7 builds on the (aarch64) p2 devices (bug 1553310) even though we're moving aarch64 tests to ARM64 Windows.

Summary: Turn off jittest on android 8.0 aarch64 platform → Turn off jittest on android-hw-8.0-aarch64, instead run SM(p) on integration branches
Priority: -- → P3
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/75730b6eaa7b
disable jittest on android-hw aarch64, instead run windows10-aarch64 SM(p) on integration branches r=gbrown
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.