Closed Bug 1553642 Opened 2 years ago Closed 2 years ago

Enable the check for userChrome.css and userContent.css by default after bug 1541233

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file)

Bug 1541233 removes the automatic check of the existence of userChrome.css or userContent.css to apply them.

TB is not so critical on the startup time like FX that the disk access to check of the existence slows the start when other things like mailbox access or Lightning take a lot more time.

So we should enable the pref by default.

Bug 1541233 is not landed yet, so no rush. But we could land it also before without harm.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9066849 - Flags: review?(mkmelin+mozilla)

(In reply to Richard Marti (:Paenglab) from comment #0)

TB is not so critical on the startup time like FX

What, why do you say that? Of course we very much need to look at start-up time as much as we can.

Comment on attachment 9066849 [details] [diff] [review]
1553642-enable-userChrome-userContent.patch

Review of attachment 9066849 [details] [diff] [review]:
-----------------------------------------------------------------

Since bug 1550157 already sets the pref to true for users who already has these files, I don't see why we should set it to true for others. 
If they want to add a css customization file, surely they are also capable of setting the hidden toolkit.legacyUserProfileCustomizations.stylesheets pref too.
Attachment #9066849 - Flags: review?(mkmelin+mozilla) → review-
Comment on attachment 9066849 [details] [diff] [review]
1553642-enable-userChrome-userContent.patch

(In reply to Magnus Melin [:mkmelin] from comment #2)
> (In reply to Richard Marti (:Paenglab) from comment #0)
> > TB is not so critical on the startup time like FX 
> 
> What, why do you say that? Of course we very much need to look at start-up time as much as we can.

It's about some ms for the disk access to check for the existence of this files.

(In reply to Magnus Melin [:mkmelin] from comment #3)
> Comment on attachment 9066849 [details] [diff] [review]
> 1553642-enable-userChrome-userContent.patch
> 
> Review of attachment 9066849 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Since bug 1550157 already sets the pref to true for users who already has
> these files, I don't see why we should set it to true for others. 
> If they want to add a css customization file, surely they are also capable
> of setting the hidden toolkit.legacyUserProfileCustomizations.stylesheets
> pref too.

Bug 1541233 removes this automatism again (https://phabricator.services.mozilla.com/D31670). It's only for 68 automatic.
Attachment #9066849 - Flags: review- → review?(mkmelin+mozilla)

Yes, but then all existing users are migrated, assuming they at one point run 68 (which sounds like a fair assumption), no?

Okay.

Attachment #9066849 - Flags: review?(mkmelin+mozilla)
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.