Closed Bug 1553715 Opened 6 years ago Closed 6 years ago

lando-api: publish secure commit message if one has been given

Categories

(Conduit :: Lando, task, P2)

Product:
Conduit
Component:
Lando
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1569074

People

(Reporter: mars, Assigned: mars)

References

(Blocks 1 open bug)

Details

(Keywords: conduit-triaged)

Lando presents a sec-approved preview page with sanitized messages

  • API method to read revision comments
  • function to pick sanitized message from revision comment list
    • heuristic for finding our messages. sentinel?
    • Need to avoid message spoofing?
      • Maybe store msg+rev_id in table to prevent spoofing/tampering. Maybe store just hash to save space.
  • test: should ignore older messages
  • test: no messages? redirect to input workflow?
  • How to handle a failure to communicate with phabricator?
  • substitute sanitized message into API return calls if revision in "secure" state
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.