1569074 - [lando-api] Lando presents the landing preview page with an approved sanitized commit message

Status: RESOLVED FIXED

(Conduit :: Lando, task, P2)

Description

[Māris Fogels [:mars] (please needinfo)]

After the sec-approval team has approved a Phabricator revision with a sanitized commit message, then a developer visiting Lando UI should see the approved sanitized commit message in the UI instead of the original commit message.

Rough notes:

• PhabricatorClient method to read a comment list?
• Function to pick the correct sanitized message out of the list of comments
  • Use transaction PHID from writing the sanitized message comment to pick the comment out of the comment thread
  • Acceptance test: older sanitized messages, approved or denied, should be ignored
  • Return HTTP 502 if Phabricator is down
• Possible UI changes to let the lander know they are not viewing the original commit message.

Comment 2

[Māris Fogels [:mars] (please needinfo)]

Attachment: GitHub Pull Request

Comment 3

[Māris Fogels [:mars] (please needinfo)]

This has been deployed to dev for testing.

Comment 4

[Māris Fogels [:mars] (please needinfo)]

I've verified the code works on dev.

Comment 5

[Māris Fogels [:mars] (please needinfo)]

This has been deployed to production.