Closed Bug 1553910 Opened 5 years ago Closed 5 years ago

ClearType pixel order not respected by WebRender

Categories

(Core :: Graphics: WebRender, defect, P1)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
relnote-firefox --- 67+
firefox67 --- wontfix
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: rowbot, Assigned: lsalzman)

References

Details

Attachments

(1 file)

A reddit user has reported that when enabling webrender on Windows 7 with an nvidia GPU, they are seeing colorful fringes around all text.

https://www.reddit.com/r/firefox/comments/brw6c7/post_your_webrender_results/eoh8rqb?utm_source=share&utm_medium=web2x

A sc

Blocks: wr-win7

User's about:support: https://pastebin.com/S09wpvS7
Screenshot comparison: https://imgur.com/a/dR6KO2z

I see in the supplied about:support, the ClearType Pixel Structure is BGR. Is that something that webrender handles or does it only support RGB for ClearType?

Priority: -- → P3

It seems like this is a problem on Win10 as well.

Summary: Colorful fringes around text on Windows 7 → ClearType pixel order not respected by WebRender
Blocks: wr-68
No longer blocks: wr-win7
Priority: P3 → P2
Priority: P2 → P1

We also seem to have this problem if Direct2D is disabled.

Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dae9fa100abe
pass DWrite subpixel order into Skia and WebRender. r=jrmuizel
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9067467 [details]
Bug 1553910 - pass DWrite subpixel order into Skia and WebRender. r?jrmuizel

Beta/Release Uplift Approval Request

  • User impact if declined: Color fringing on text on screens using a different subpixel order.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This isn't too risky, it's mostly just plumbing some state around.
  • String changes made/needed:
Attachment #9067467 - Flags: approval-mozilla-beta?

Julien, is possible to add something to 67 release notes about their being color fringing on text on screens with BGR pixel order when WebRender is enabled?

Flags: needinfo?(jcristau)
OS: Windows 7 → Windows

Some background on estimated impact of this issue:

  • We only discovered the problem through a user that manually enabled WebRender on win7
  • The problem has existed for the lifetime of WebRender (i.e it's been on Nightly since September 2018)
  • The same problem happens when ever Direct2D is disabled. Direct2D is disabled for approx 25% of Windows users

Added as a known issue to the Fx67 release notes. Doesn't seem likely that we're going to try to backport this fix to a 67 dot release, though, so marking that as wontfix.

Flags: needinfo?(jcristau)

Comment on attachment 9067467 [details]
Bug 1553910 - pass DWrite subpixel order into Skia and WebRender. r?jrmuizel

webrender fix for 68.0b6

Attachment #9067467 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: