Closed Bug 1553926 Opened 3 months ago Closed 3 months ago

Add fetch-options eslint plugin to mozilla central (or merge into the mozilla plugin)

Categories

(Firefox :: Messaging System, task, P1)

task

Tracking

()

RESOLVED FIXED
Firefox 69
Iteration:
69.2 - May 27 - Jun 9
Tracking Status
firefox69 --- fixed

People

(Reporter: k88hudson, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

In order to support mach eslint for browser/components/newtab we need to have fetch-options available. What do you think about merging this into the general mozilla eslint plugin or adding it to firefox's package.json?

Assignee: nobody → andrei.br92
Type: defect → task
Flags: needinfo?(andrei.br92)

Tried that previously when we merged the plugin in github but m-c has more ways of calling fetch that the plugin wasn't expecting. I didn't have time then to investigate more but I can have a look now.

Flags: needinfo?(andrei.br92)

We could disable the rule for everywhere apart from newtab for now. Depends on if you think it'll still make sense to have the rule once it accounts for the other usages?

Iteration: --- → 69.2 - May 27 - Jun 9
Priority: -- → P1
Blocks: 1557040
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f392f0afb49
Add fetch-options eslint plugin to mozilla central r=Standard8
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.