Closed
Bug 1553926
Opened 5 years ago
Closed 5 years ago
Add fetch-options eslint plugin to mozilla central (or merge into the mozilla plugin)
Categories
(Firefox :: Messaging System, task, P1)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: k88hudson, Assigned: andreio)
References
Details
Attachments
(2 files)
In order to support mach eslint for browser/components/newtab we need to have fetch-options available. What do you think about merging this into the general mozilla eslint plugin or adding it to firefox's package.json?
|
Reporter | |
Updated•5 years ago
|
Assignee: nobody → andrei.br92
Type: defect → task
Flags: needinfo?(andrei.br92)
|
Assignee | |
Comment 1•5 years ago
|
||
Tried that previously when we merged the plugin in github but m-c has more ways of calling fetch that the plugin wasn't expecting. I didn't have time then to investigate more but I can have a look now.
Flags: needinfo?(andrei.br92)
|
||
Comment 2•5 years ago
|
||
We could disable the rule for everywhere apart from newtab for now. Depends on if you think it'll still make sense to have the rule once it accounts for the other usages?
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
Iteration: --- → 69.2 - May 27 - Jun 9
Priority: -- → P1
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5f392f0afb49 Add fetch-options eslint plugin to mozilla central r=Standard8
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → Messaging System
You need to log in
before you can comment on or make changes to this bug.
Description
•