1553926 - Add fetch-options eslint plugin to mozilla central (or merge into the mozilla plugin)

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Kate Hudson :k88hudson]

In order to support mach eslint for browser/components/newtab we need to have fetch-options available. What do you think about merging this into the general mozilla eslint plugin or adding it to firefox's package.json?

Comment 1

[Andrei Oprea [:andreio]]

Tried that previously when we merged the plugin in github but m-c has more ways of calling fetch that the plugin wasn't expecting. I didn't have time then to investigate more but I can have a look now.

Comment 2

[Mark Banner (:standard8)]

We could disable the rule for everywhere apart from newtab for now. Depends on if you think it'll still make sense to have the rule once it accounts for the other usages?

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Bug 1553926 - Add fetch-options eslint plugin to mozilla central

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5070

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f392f0afb49
Add fetch-options eslint plugin to mozilla central r=Standard8

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5f392f0afb49