1553972 - make --with-pgo-profile-path take a directory

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1553972 - make --with-pgo-profile-path take a directory; r=#build

e10s profiling or IR-based PGO instrumentation will both produce
multiple .profraw files that need to be handled in some way. Since
clang's -fprofile-generate option takes a directory, it seems fitting
to make --with-pgo-profile-path mirror that by taking a directory, and
letting merge_profdata.py deal with whatever files it might find in
said directory.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99dfff71a4ca
make --with-pgo-profile-path take a directory; r=nalexander

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/99dfff71a4ca

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9067181 [details]
Bug 1553972 - make --with-pgo-profile-path take a directory; r=#build

Beta/Release Uplift Approval Request

• User impact if declined: Fennec Beta and Release won't have PGO'd builds
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1553065
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Tested at https://bugzilla.mozilla.org/show_bug.cgi?id=1553065#c23
• String changes made/needed: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9067181 [details]
Bug 1553972 - make --with-pgo-profile-path take a directory; r=#build

Prerequisite patch for bug 1553065. Approved for 68.0b11.

Comment 6

[Johan Lorenzo [:jlorenzo]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a8333688fcbe