Enable some ESLint rules for more of layout/

RESOLVED FIXED in Firefox 69

Status

()

task
RESOLVED FIXED
2 months ago
7 days ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 1 bug)

Trunk
mozilla69
Points:
2
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

As part of rolling out ESLint across the tree, I'd like to enable it for the layout/ directory.

The first stage to this is enabling ESLint on the directories, and disabling the rules that fail. This gives us the benefit of at least syntactical checks to begin with plus some rules being enabled.

Some of the disabled rules are style related, those we'll defer to later as we're looking into rolling out js formatting across the tree (and might as well take the reformatting hit one-time).

For enabling the other rules I will file mentored follow-up bug(s) after this lands.

The code changes I'm landing in this bug are for supporting the ESLint rule no-shadow. These were fairly simple there was just quite a few of them. There were one or two places I whitelisted, as it didn't make sense to fix the whole file.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9dcf4317c50c
Enable some ESLint rules for more of layout/. r=dholbert
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2283a3e7f2de
Fix failures on test_media_queries. r=Standard8
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Iteration: --- → 69.1 - May 13 - 26
You need to log in before you can comment on or make changes to this bug.