Open Bug 1554399 Opened 9 months ago Updated 3 months ago

incorrect media sort by size in view page info

Categories

(Firefox :: Page Info Window, defect, P3)

67 Branch
Desktop
All
defect

Tracking

()

Tracking Status
firefox-esr60 --- unaffected
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- fix-optional
firefox69 --- fix-optional
firefox70 --- fix-optional

People

(Reporter: ripaemilian, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

  1. open some page
  2. open context menu > view page info > media
  3. try to sort by size several times

Actual results:

  1. not every click sorts column
  2. incorrect sort order

example (67.0):
(gif) https://gfycat.com/ru/flickeringvaguebovine

Expected results:

Media content correctly sorted by size.

example (66.0):
(gif) https://gfycat.com/uncomfortablescrawnyamethystgemclam

Component: Untriaged → Page Info Window

I can reproduce the issue on Nightly69.0a1 Windows10.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0a4aefb36aff504e179121c8de0039c0df9e8106&tochange=03aece6cda47ff158485d986e19ba230ea4c8834

Regressed by:
03aece6cda47ff158485d986e19ba230ea4c8834 Christian Frey — Bug 1517493 - migrated pageInfo.dtd and pageInfo.properties to pageInfo.ftl r=jaws,flod,Gijs

Chris Frey,
Your patch seems to cause the regression. Can you please look into this?

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(freychr3)
Keywords: regression
OS: Unspecified → All
Regressed by: 1517493
Hardware: Unspecified → Desktop
QA Whiteboard: [qa-regression-triage]

Thanks for the report!

I can reproduce both problems on my machine.

  • clicking doesn't work sometimes
  • Sorting order is wrong

Honza

Priority: -- → P3

This is broken because https://searchfox.org/mozilla-central/rev/f91bd38732d4a330eba4e780812274b98eb81274/browser/base/content/pageinfo/pageInfo.js#185-186 expects to be comparing numbers, but the change at https://hg.mozilla.org/mozilla-central/rev/03aece6cda47#l1.204 from bug 1517493 changed the addImage function to make it format and localize file sizes into strings eagerly.

Also have the sorting issue in the view properties > image

Windows 7, 64 bit SP1
Firefox Quantum 68.0 (64-bit)

I seemed to see an inference to a possible fix for this version of firefox, but could not locate it. Anyone have a link to this fix (if it exists)?

Problem persists in 68.0.1 (64-bit).

Any proposed fix, or barring that, any known workarounds?

Duplicate of this bug: 1565404

Adding needinfo on Jared who participated in bug 1517493.

Flags: needinfo?(jaws)
Duplicate of this bug: 1571575
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Flags: needinfo?(freychr3)

This is safe because we only display the sizes as kb so we don't have to worry about comparing different units.

QA Whiteboard: [qa-regression-triage]

I won't be able to continue with this bug as I'm going on extended leave.

Assignee: jaws → nobody
Status: ASSIGNED → NEW
Attachment #9083535 - Attachment is obsolete: true

Happy to take a patch for 70 or beyond.
Since we are getting close to the end of the 69 beta cycle and this is set to P3, I'm marking it fix-optional for 69 and 70 to remove it from weekly triage.

Duplicate of this bug: 1590243

In FF71 this bug is still existant.

You need to log in before you can comment on or make changes to this bug.