incorrect media sort by size in view page info
Categories
(Firefox :: Page Info Window, defect, P3)
Tracking
()
People
(Reporter: ripaemilian, Unassigned, NeedInfo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0
Steps to reproduce:
- open some page
- open context menu > view page info > media
- try to sort by size several times
Actual results:
- not every click sorts column
- incorrect sort order
example (67.0):
(gif) https://gfycat.com/ru/flickeringvaguebovine
Expected results:
Media content correctly sorted by size.
example (66.0):
(gif) https://gfycat.com/uncomfortablescrawnyamethystgemclam
Comment 1•5 years ago
|
||
I can reproduce the issue on Nightly69.0a1 Windows10.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0a4aefb36aff504e179121c8de0039c0df9e8106&tochange=03aece6cda47ff158485d986e19ba230ea4c8834
Regressed by:
03aece6cda47ff158485d986e19ba230ea4c8834 Christian Frey — Bug 1517493 - migrated pageInfo.dtd and pageInfo.properties to pageInfo.ftl r=jaws,flod,Gijs
Chris Frey,
Your patch seems to cause the regression. Can you please look into this?
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Thanks for the report!
I can reproduce both problems on my machine.
- clicking doesn't work sometimes
- Sorting order is wrong
Honza
Comment 3•5 years ago
|
||
This is broken because https://searchfox.org/mozilla-central/rev/f91bd38732d4a330eba4e780812274b98eb81274/browser/base/content/pageinfo/pageInfo.js#185-186 expects to be comparing numbers, but the change at https://hg.mozilla.org/mozilla-central/rev/03aece6cda47#l1.204 from bug 1517493 changed the addImage function to make it format and localize file sizes into strings eagerly.
Also have the sorting issue in the view properties > image
Windows 7, 64 bit SP1
Firefox Quantum 68.0 (64-bit)
I seemed to see an inference to a possible fix for this version of firefox, but could not locate it. Anyone have a link to this fix (if it exists)?
Comment 5•5 years ago
|
||
Problem persists in 68.0.1 (64-bit).
Any proposed fix, or barring that, any known workarounds?
Comment 7•5 years ago
|
||
Adding needinfo on Jared who participated in bug 1517493.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 9•5 years ago
|
||
This is safe because we only display the sizes as kb so we don't have to worry about comparing different units.
Updated•5 years ago
|
Comment 10•5 years ago
|
||
I won't be able to continue with this bug as I'm going on extended leave.
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Happy to take a patch for 70 or beyond.
Since we are getting close to the end of the 69 beta cycle and this is set to P3, I'm marking it fix-optional for 69 and 70 to remove it from weekly triage.
Comment 13•4 years ago
|
||
In FF71 this bug is still existant.
Comment 14•4 years ago
|
||
Same. Firefox 77.0b3 x64, Windows 10.0.18363.815.
https://s8.hostingkartinok.com/uploads/images/2020/05/e2bddbe59de8198e692c78fb3e28b055.png
Comment 16•4 years ago
|
||
Comment 17•4 years ago
|
||
Still not sorting correctly in Windows and Linux with Firefox 76.0.1
Comment 18•4 years ago
|
||
How does this bug still exist over a year later?
Comment 19•4 years ago
|
||
Comment 20•4 years ago
|
||
Firefox 82.0 64bits / Windows 10 Home 1909 (18363.1139)
Comment 21•3 years ago
|
||
Still present in FF 88.0. Writing this comment in hopes that the bug gets some attention from the developers.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Comment 22•2 years ago
|
||
The severity field for this bug is relatively low, S3. However, the bug has 4 duplicates.
:florian, could you consider increasing the bug severity?
For more information, please visit auto_nag documentation.
Comment 23•2 years ago
|
||
The good news: it sorts correctly now
The bad news: that is because nearly every filesize is now Unknown! (I've tested +-15 sites, only 2 of them had 1 item of non-unknown size)
How has a simple bug like this not yet been fixed and gotten even worse?!?
Comment 24•2 years ago
|
||
Comment 25•5 months ago
|
||
Bump. A 5 year old issue, something as trivial and simple as sorting by size, is somehow still not resolved. (And every 1st out of 3 clicks does nothing.)
Description
•