1554527 - Slow Firefox UI with YouTube in a container

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Okarin]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

With Nightly (Build ID: 20190526093457):

• Create a new profile
• Open a new tab in a container (long click on "+" or right click -> Reopen in Container)
• Browse to https://www.youtube.com/watch?v=qldxyjEjjBQ
• Scroll down until the last comment

Actual results:

Each interaction with UI is slow: switching tabs, moving window, clicking on buttons etc.

Expected results:

Firefox should run smoothly (as usual).

Comment 1

[Okarin]

Mozregression:
app_name: firefox
build_date: 2019-05-24 20:50:28.918000
build_file: C:\Users\Okarin.mozilla\mozregression\persist\daf113171d63-shippable--autoland--target.zip
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/BZr7cSNUQCCP-OqakLP-FQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: daf113171d6342f925fb8265cdbee384c7f64dc3
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=181ef326f7a8f6e604db2d55a3cca175ae396c7b&tochange=daf113171d6342f925fb8265cdbee384c7f64dc3
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: BZr7cSNUQCCP-OqakLP-FQ

Differential Revision: https://phabricator.services.mozilla.com/D32364

Comment 2

[Sean Feng [:sefeng]]

I also experienced a similar issue. I was running latest nightly on Linux, and whenever I opened an Youtube tab, my fan would start to spin and I could feel the UI was slow and janky.

About:support: https://pastebin.com/f7360cYE
Profile: https://perfht.ml/2wl2Xlp

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 1554527 - Clone the principal for permission checks in CookieSettings only if needed, r?ehsan

Comment 4

[Andrea Marchesini [:baku]]

I don't know if my patch fixes this issue, but definitely, the creation of the principal can be avoided if there are no permissions involved.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e85291f97de
Clone the principal for permission checks in CookieSettings only if needed, r=Ehsan

Comment 7

[Daniel Bodea [:danibodea]]

Setting flags based on the regressor's pushed changeset.

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1e85291f97de

Comment 9

[Okarin]

I can still reproduce the issue with latest nightly (build 20190528172821).

Comment 10

[Alice0775 White]

(In reply to Okarin from comment #9)

I can still reproduce the issue with latest nightly (build 20190528172821).

I can also reproduce the UI freeze and high CPU usage and high memory usage.
Filed Bug 1555166

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out as requested by Sylvestre for causing huge perf regressions. https://hg.mozilla.org/mozilla-central/rev/3a79d3be67486be1d30bda47988cf8c76ee3a3ee

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This was fixed by the backout of bug 1553867.

Comment 14

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.

Comment 15

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #14)

This bug has been identified as part of a pilot on determining root causes of blocking and dot release drivers.

It needs a root-cause set for it. Please see the list at https://docs.google.com/document/d/1FFEGsmoU8T0N8R9kk-MXWptOPtXXXRRIe4vQo3_HgMw/.

Add the root cause as a whiteboard tag in the form [rca - <cause> ] and remove the rca-needed keyword.

If you have questions, please contact :tmaity.

Hi :baku, as you were the assignee of this bug, I think you are the best person to determine the root cause. Could you please follow comment 14? Thank you.

Comment 16

[Andrea Marchesini [:baku]]

[rca - Logical Error] but it should be more a performance issue.