1554540 - Expose window protocol (X11, Wayland) in about:support and telemetry

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

It will be useful to know which window protocol is in use when users report issues without having to ask explicitly, as Wayland specific issues are cropping up more and more. Ideally this will be included by default in about:support and telemetry (including crash reports).

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1554540 - Expose window protocol (X11, Wayland) in nsIGfxInfo and about:support.

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1554540 - Part 2. Expose window protocol from nsIGfxInfo in about:support and telemetry.

Comment 3

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Data review request, v1

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9067671 [details]
Data review request, v1

I'll just include this in about:support and add a boolean to the crash reports, as discussed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8e48e2861c5
Expose window protocol (X11, Wayland) in nsIGfxInfo and about:support. r=kats,stransky,flod

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca4f3b736dd6
Follow up to fix broken browser chrome tests. r=aosmond

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/c8e48e2861c5
https://hg.mozilla.org/mozilla-central/rev/ca4f3b736dd6

Comment 9

[Mike Hommey [:glandium]]

It feels like something that could be useful to have in ESR68.

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Mike Hommey [:glandium] from comment #9)

It feels like something that could be useful to have in ESR68.

I have no opposition to this. Will request.

Comment 11

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9067668 [details]
Bug 1554540 - Expose window protocol (X11, Wayland) in nsIGfxInfo and about:support.

Beta/Release Uplift Approval Request

• User impact if declined: We will need to be mindful when interpreting user reports if they don't mention X11 vs Wayland usage.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just adds a new field in about:support. It is a very simple change which required a fair bit of boilerplate plumbing that is hard to go terribly wrong.
• String changes made/needed: Adds "Window Protocol" to the about:support localization; used on Linux only

Comment 12

[Julien Cristau [:jcristau] (back August 18)]

(In reply to Andrew Osmond [:aosmond] from comment #11)

Beta/Release Uplift Approval Request

[...]

• String changes made/needed: Adds "Window Protocol" to the about:support localization; used on Linux only

flod, is this ok?

Comment 13

[Francesco Lodolo [:flod]]

Yes, it's just Linux and quite hidden.

Comment 14

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9067668 [details]
Bug 1554540 - Expose window protocol (X11, Wayland) in nsIGfxInfo and about:support.

add some info in about:support on linux, approved for 68.0b7

Comment 15

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e5980a74c9c

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d9e4be41b43a