1554610 - Single pixel (white/black) hole in top left window corner on Windows 10 with double buffering and Basic compositor

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[Kestrel]

Attachment: White pixel in top left corner of window

Windows 10 1903 running in VirtualBox 6.0.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=34a413cfb0d225c4a2007b4d37bb63087d5a1436&tochange=e96752781d2d3961d797cec48c5357c4ec293a23

Regressed by Bug 1549674.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Copying Bas' comment from bug 1555956 comment #11:

My best guess here is that this is a debug feature in VirtualBox that is accidentally leaking in somewhere, they might put some kind of debugging info for their graphics driver development for double buffering in that single pixel. The easiest solution in my mind would be to disable double buffering on VirtualBox, or for that matter, perhaps blacklist it by default altogether, I'm not certain they win much by it.

Comment 2

[Kestrel]

It's not limited to VirtualBox, I've also seen it on an ancient netbook device.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Bas, were you able to reproduce this in VirtualBox?

Comment 4

[08xjcec48]

This affects Firefox on my notebook with first-generation Intel HD Graphics and hardware acceleration disabled manually.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Comment 5

[Jeff Muizelaar [:jrmuizel]]

"Hide my Email", to confirm, you only see the problem with hardware acceleration disabled?

Comment 6

[08xjcec48]

The answer is yes.

I had mentioned it just to say that I wasn't even trying to use hardware acceleration, since I assumed it wouldn't do anything on such an old graphics chip anymore, and I had problems with it back when it was first implemented.

However, after your question I checked "Use hardware acceleration when available" and the annoying pixel was gone.

Comment 7

[Kestrel]

I can confirm this only happens with hardware acceleration disable (Basic compositor, layers.acceleration.disabled = true) and can be worked around by disabling double buffering (gfx.direct3d11.use-double-buffering = false).

Comment 8

[Sotaro Ikeda [:sotaro]]

Double buffering was disabled on beta by Bug 1610912.

Comment 9

[Sotaro Ikeda [:sotaro]]

When BasicCompositor is used, BasicCompositor does not use CompositorWindow. Then CompositorWindow exists as initial one pixel size.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1554610 - Destroy CompositorWindow if BasicCompositor is used

Comment 11

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08692b3e454470212477ea82d808ffcfef4d08ad

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d780e5d16e4f
Destroy CompositorWindow if BasicCompositor is used r=nical

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d780e5d16e4f