Closed Bug 1580222 Opened 5 months ago Closed 5 months ago

Let double buffering ride the trains

Categories

(Core :: Graphics, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- disabled
firefox72 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

(Depends on 3 open bugs, Regressed 1 open bug)

Details

Attachments

(2 files)

No description provided.
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7df49da41ea1
Let double buffering ride the trains. r=aosmond
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Assignee: nobody → jmuizelaar
Depends on: 1586555
Depends on: 1586130
Depends on: 1573710
See Also: → 1579732

Jeff, given that there are several regressions unfixed identified over the last months (bug 1579732, bug 1586130) should double buffering be deactivated for 71 or are you confident that this is good enough for the release channel? Thanks.

Flags: needinfo?(jmuizelaar)

We have a couple of regressions double buffer.
Let's turn it off for now to avoid the risk of breaking things.

Comment on attachment 9111352 [details]
Bug 1580222. Turn off double buffering in 71.

Beta/Release Uplift Approval Request

  • User impact if declined: Bug 1586130 and bug 1579732
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Low risk. This what we shipped in 70.
  • String changes made/needed:
Flags: needinfo?(jmuizelaar)
Attachment #9111352 - Flags: approval-mozilla-release?

Comment on attachment 9111352 [details]
Bug 1580222. Turn off double buffering in 71.

Reduces risk for the release, uplift approved to 71 RC, thanks

Attachment #9111352 - Flags: approval-mozilla-release? → approval-mozilla-release+

Are we ok with this shipping in 72?

Flags: needinfo?(jmuizelaar)

Yep.

Flags: needinfo?(jmuizelaar)
Regressions: 1608485
Depends on: 1600582
Depends on: 1554610
You need to log in before you can comment on or make changes to this bug.