1554761 - Find in page value reappearing

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[u635235]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. Open the find in page bar by pressing Cmd + F
2. Type some text in
3. Close the find in page bar
4. Re-open the find in page bar
5. Delete all text in the find in page bar
6. Click outside the find in page bar
7. Click in the find in page bar input field

Actual results:

At step 4 the text is often shorter than the text entered in step 2, if it is say eight characters long it will end up being 3-4.

At step 7 the find in page bar input field will contain the text deleted in step 5.

Expected results:

At step 4 the text should be exactly the same as it was when the find in page bar was closed in step 3.

At step 7 the find in page bar input field should be blank, having been deleted in step 5.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mike de Boer [:mikedeboer]]

I can reproduce this behavior, but I'm not sure if it's critical issue.
This is a problem with the interaction between the find toolbar and the OSX system-wide Find clipboard. What I see in other Mac apps is that indeed each typed sequence of characters is saved to the Find clipboard, not just the successful finds.
I'll take a look at this, see how much I can fix this up.

Thanks for filing!

Comment 3

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Small refactor, made possible because the findbar is now a custom element, implemented as a JS module. r?Gijs!

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Align findbar interaction with the Mac OSX find clipboard to match common behavior of system apps. r?dao!

Depends on D38639

Comment 5

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Add test coverage for the newly introduced BrowserWindowTracker observer notification. r?dao!

Depends on D38640

Comment 6

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=462abb68046b6be5b7881f20ee5024c458fa2c0e

Comment 7

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Switch the remaining findbar strings over to Fluent. r?dao!

Depends on D38639

Comment 8

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Add test coverage for the updated behavior of the findbar input when the application activated again and the find clipboard value changed. r?dao!

Depends on D38641

Comment 9

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Notify with a 'mac_app_activate' topic when the App has been activated, capturing Command-Tabbing behavior. OSX only. r?spohl!

Depends on D39383

Comment 10

[Mike de Boer [:mikedeboer]]

Zibi, setting the needinfo flag in order to continue the conversation in Phabricator.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df0d308f3d6d
Small refactor, made possible because the findbar is now a custom element, implemented as a JS module. r=Gijs

Comment 12

[Mike de Boer [:mikedeboer]]

Backed out in https://hg.mozilla.org/integration/autoland/rev/9ebe1a1c52a5.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2581a2452450
Small refactor, made possible because the findbar is now a custom element, implemented as a JS module. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/9f0da81292cc
Align findbar interaction with the Mac OSX find clipboard to match common behavior of system apps. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/48b38cc561d4
Notify with a 'mac_app_activate' topic when the App has been activated, capturing Command-Tabbing behavior. OSX only. r=spohl

Comment 14

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1554761 - Follow-up to add a module import/ constant that I accidentally removed in Part 2. r?Gijs!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60fdca0bdbef
Follow-up to add a module import/ constant that I accidentally removed in Part 2. r=Gijs

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2581a2452450
https://hg.mozilla.org/mozilla-central/rev/9f0da81292cc
https://hg.mozilla.org/mozilla-central/rev/48b38cc561d4
https://hg.mozilla.org/mozilla-central/rev/60fdca0bdbef

Comment 17

[Oana Botisan, Desktop QA]

I managed to reproduce the issue on an older version of Nightly from 2019-05-27 using macOS 10.15.
However, when I open the latest Nightly 74.0a1 with a new profile, the Find Toolbar still contained a few of the letters from the word I input in the field in the affected build.
After I redid the steps on Nightly 74.0a1, the bug didn't reproduce.
Is this normal behaviour?

Comment 18

[Mike de Boer [:mikedeboer]]

Yes.

Comment 19

[Oana Botisan, Desktop QA]

According to comment 17 and comment 18 I will mark this bug as verified fixed.