Closed
Bug 1554938
Opened 5 years ago
Closed 5 years ago
WelcomeBox text is too thin on macOS, hard to read on non-retina displays
Categories
(DevTools :: Debugger, defect, P5)
DevTools
Debugger
Tracking
(firefox69 fixed)
RESOLVED
FIXED
Firefox 69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: fvsch, Assigned: fvsch)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(3 files)
Style:
.welcomebox {
…
font-weight: lighter;
…
}
This maps to font-weight: 100
, basically asking the browser for a "hairline" font. Since the system font we use on different platforms tends to not have such low weights, we often end up with normal text or a light-but-not-too-light font.
On macOS we do get a very thin font, since San Francisco Text seems to be a variable font (I'm getting visibly different results with 300
, 350
and 400
weights).
Generally speaking, very thin fonts are only relevant for very large text (large titles). They're often too hard to read at low sizes.
Proposed fixes:
- keep a normal weight, or
- if we want to keep a thin weight, avoid lighter and use
font-weight: 300
Comment 1•5 years ago
|
||
Thanks Florens. Perhaps we should use font-weight: 300
to be the same across the board?
Keywords: good-first-bug
Updated•5 years ago
|
Priority: -- → P5
Updated•5 years ago
|
Blocks: dbg-frontend
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
Sounds reasonable. Just pushed my biggest patch ever :D
Assignee | ||
Comment 4•5 years ago
|
||
Result on macOS at 1x.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → florens
Status: NEW → ASSIGNED
Pushed by florens@fvsch.com:
https://hg.mozilla.org/integration/autoland/rev/4bf30a3b7029
Make WelcomeBox text less thin for readability on low res; r=jlast
Comment 6•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
You need to log in
before you can comment on or make changes to this bug.
Description
•