1555048 - DS card impression observer position issue

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Looks like a small bug was introduced with 1550160

The impression observer now no longer overlaps over the rest of the card.

I think the fix here isn't to revert 1550160 but to add a top:0 to the impression overlay.

Comment 1

[Scott [:thecount] Downe]

To test:

1. load a new tab, probably fresh profile
2. inspect a card
3. look for the class="impression-observer" element
4. ensure it's overlapping the rest of the card, and not hovering under it.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5074

Comment 3

[Tim Spurway [:tspurway]]

[Tracking Requested - why for this release]: this bug affects impression tracking and users without the fix will see more sponsored content than is expected

Comment 4

[Scott [:thecount] Downe]

My mistake, I thought this bug was in beta, but it is not.

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/07bb612a30b0

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (69.0a1 Build ID - 20190602221035) installed, on Windows 10 x64, Arch Linux and Mac 10.14.5. Now, the class="impression-observer" element overlaps the card.