Closed Bug 1555088 Opened 1 year ago Closed 1 year ago

Lessen startup IO by using a different method to determine an update was performed other than reading the update.status file

Categories

(Toolkit :: Application Update, defect, P2)

68 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

Spinoff of Bug 1446012 and specifically Bug 1446012 comment #8

I've been thinking about this a bit and I think the code can be changed as follows:

Replace the use of the app.update.postupdate pref in BrowserContentHandler.jsm with a check for if there is an activeUpdate for OVERRIDE_NEW_MSTONE and OVERRIDE_NEW_BUILD_ID. For the OVERRIDE_NEW_MSTONE case when there is an activeUpdate it can be passed to getPostUpdateOverridePage and when there isn't an activeUpdate it can just use the value of the startup.homepage_override_url pref.
https://searchfox.org/mozilla-central/source/browser/components/BrowserContentHandler.jsm#555-577

Remove the following from UpdateService.jsm
https://searchfox.org/mozilla-central/source/toolkit/mozapps/update/UpdateService.jsm#1889-1894

Replace the following so it just QI's the activeUpdate to nsIWritablePropertyBag.
https://searchfox.org/mozilla-central/source/browser/components/BrowserContentHandler.jsm#143-158

Changes BrowserContentHandler.jsm to rely on whether there is a version change and an active update to determine whether to check for a what's new page and send an update ping
Changes BrowserContentHandler.jsm to rely on whether there is a build ID change and an active update to determine whether to send an update ping
Removes reading of the update.status file in UpdateService.jsm UpdateService::observe post-update-processing which is called during the profile-after-change observer notification

Attachment #9070741 - Attachment is obsolete: true

Well, this is annoying. There are several other consumers that have decided to use the pref! Good times...

As suggested in comment #0, this can't be implemented unless nsHandlerService-json.js no longer has a dependency on the app.update.postupdate pref which was added in bug 1389443 so wontfixing. If a different method comes to mind I'll file a bug for it.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → WONTFIX

Attaching this for safe keeping until after bug 1446012 is fixed or wontfixed.

The Pdfjs code in bug 1559195 is just being removed, but is actually already dead, so I'm gonna reopen this. :-)

Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Status: REOPENED → ASSIGNED
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9da065181d29
Use activeUpdate and an app version increase to determine that an update was performed and remove the post update pref. r=bytesized
Status: ASSIGNED → RESOLVED
Closed: 1 year ago1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.