1555165 - Parse backdrop-filter CSS property

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Connor Brewster [:cbrewster]]

Spec: https://drafts.fxtf.org/filter-effects-2/#propdef-backdrop-filter

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Probably worth waiting me to land bug 1552878, which will make this a one-liner basically?

Comment 2

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555165 - Part 1: Parse backdrop-filter CSS property r?emilio,boris

Comment 3

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555165 - Part 0: clang format nsStyleStruct.h/cpp r?emilio,boris

Comment 4

[Connor Brewster [:cbrewster]]

Attachment: Bug 1555165 - Part 2: Update backdrop-filter WPT tests and expectations r?emilio,boris

Depends on D35816

Comment 5

[Connor Brewster [:cbrewster]]

Treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9802fad44ec8c8ccf3326cf7c75967576db855b&selectedJob=253578388

Comment 6

[Daniel Holbert [:dholbert]]

Triggered autoland.

Comment 7

[Daniel Holbert [:dholbert]]

Hmm, I think this might need a rebase - something must've changed on mozilla-central recently (or even more recently on autoland), perhaps.

The specific error is shown at https://lando.services.mozilla.com/D36062/ which says Details: abort: uncommitted changes. That's a slightly odd error, but I'm guessing it means the patch failed to import...?

Comment 8

[Daniel Holbert [:dholbert]]

"part 0" was the problematic bit, so I just removed that from the stack (via edit-parent-revision on part 1) and tried lando again. I'm pretty sure Lando will be able to rebase the "part 1-part2" stack on top of current autoland, because that worked locally for me.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4fecbe399e1
Part 1: Parse backdrop-filter CSS property r=emilio,boris
https://hg.mozilla.org/integration/autoland/rev/cba1f1b068da
Part 2: Update backdrop-filter WPT tests and expectations r=boris

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/e4fecbe399e1
https://hg.mozilla.org/mozilla-central/rev/cba1f1b068da

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/17701 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged