1561060 - Add filter tooltip for backdrop-filter

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Connor Brewster [:cbrewster]]

Attachment: Screen Shot 2019-06-24 at 1.10.55 PM.png

Once the backdrop-filter property CSS parsing is implemented, the DevTools should show a tooltip for editing filters similar to the filter property tooltip.

Comment 1

[Daniel Holbert [:dholbert]]

For reference, it looks like the "filter" tooltip/widget is implemented in these two JS files (at least):

https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/devtools/client/shared/widgets/tooltip/SwatchFilterTooltip.js
https://searchfox.org/mozilla-central/rev/928742d3ea30e0eb4a8622d260041564d81a8468/devtools/client/shared/widgets/FilterWidget.js

Comment 2

[Connor Brewster [:cbrewster]]

It looks like all we may need to do is add an additional check for backdrop-filter here:
https://searchfox.org/mozilla-central/source/devtools/client/shared/output-parser.js#92

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Yes, we would only need to make some changes in the output-parser.js regarding whether or not it should expectFilter.

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

I have originally set this to P3 due to the fact it has blockers. However, we can add a check for whether or not backdrop-filter is enabled in platform and if so check if the name matches backdrop-filter.

Comment 5

[Connor Brewster [:cbrewster]]

Attachment: Bug 1561060 - Enable filter tooltip for backdrop-filter in devtools r?gl

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5eaa76ed37ca
Enable filter tooltip for backdrop-filter in devtools r=gl

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5eaa76ed37ca