1555226 - [Protections Panel] Implement toggle switch flow with mini panel

Status: RESOLVED FIXED

(Firefox :: Site Identity, task, P1)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

With the current version of the patch in bug 1551902, when the toggle switch is triggered, the panel remains open and the UI changes state correctly. The specification dictates that we should wait 500ms, then refresh the page and close the panel. Once the site is done loading, we should show the mini panel indicating the new state.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

I talked to Tim and he agreed to pick this up.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1555226 - Part 1: Toggle the 'hasException' attribute on the protections panel after toggling the TP switch. r?nhnt11!

This patch moves the 'enabled' attributes to
'protections-popup-tp-switch-section' from
'protections-popup-tp-switch'. In order to change the background as
toggling the TP switch button, there should be a single attribute to
control both background and the TP switch. So, the 'enabled' attribute
should live in the section, so that both section and TP switch can
reference this value by the CSS attribute selector.

Comment 3

[Tim Huang[:timhuang]]

Attachment: Bug 1555226 - Part 2: Implementing the toggle switch flow for the TP switch section. r?nhnt11!

This patch implements the toggle switch flow. It adds a strip background
to the TP switch section after toggled the switch to off. Changing the
string in the TP switch section.

Depends on D36015

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1555226 - Part 3: Allow the protections panel to be opened as a mini panel. r?nhnt11!

This patch implements the capability for opening the protections panel
as a mini panel. The mini panel is a protections panel which only displays
the header section.

Depends on D36016

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1555226 - Part 4: Implementing the switch flow for the mini panel. r?nhnt11!

This patch makes the mini panel been shown after page reload due to
switch the tracking protection state. The mini panel will be auto hidden
after certain time, which can be configured by the pref
'browser.protections_panel.mini_panel_auto_hide_timing'. The default
value is 5 seconds.

This also implements the behavior that showing the protections panel on
clicking the mini panel.

Depends on D36017

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1555226 - Part 5: Add the badge alongside the TP switch toggle. r?nhnt11!

This patch adds the badge at the side of TP switch toggle. The badge
will only show when the TP switch toggles to off.

Depends on D36018

Comment 7

[Tim Huang[:timhuang]]

Attachment: Bug 1555226 - Part 6: Add tests for the mini panel and the TP switch flow. r?nhnt11!

This patch adds two tests. One for ensuring the mini panel is working
correctly. Another for check the correctness of the TP switch flow.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a64eedd73f97
Part 1: Toggle the 'hasException' attribute on the protections panel after toggling the TP switch. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/8e13f45f0d26
Part 2: Implementing the toggle switch flow for the TP switch section. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/ab2c77c1aa02
Part 3: Allow the protections panel to be opened as a mini panel. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/ad5b7db6a3c2
Part 4: Implementing the switch flow for the mini panel. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/734b19770a7e
Part 5: Add the badge alongside the TP switch toggle. r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/58229ee31005
Part 6: Add tests for the mini panel and the TP switch flow. r=nhnt11

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a64eedd73f97
https://hg.mozilla.org/mozilla-central/rev/8e13f45f0d26
https://hg.mozilla.org/mozilla-central/rev/ab2c77c1aa02
https://hg.mozilla.org/mozilla-central/rev/ad5b7db6a3c2
https://hg.mozilla.org/mozilla-central/rev/734b19770a7e
https://hg.mozilla.org/mozilla-central/rev/58229ee31005