Implement Tracking Protection toggle section in Protections Panel

RESOLVED FIXED in Firefox 69

Status

()

enhancement
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

(Depends on 1 bug, Blocks 1 bug)

Trunk
Firefox 69
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 wontfix, firefox69 fixed)

Details

Attachments

(5 attachments)

No description provided.
Depends on: 1555224
Depends on: 1555226
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9b7d5885e1db
Implement Tracking Protection toggle section in Protections Panel. r=johannh
https://hg.mozilla.org/integration/autoland/rev/4eeb898f69f2
Hide protections panel when focus is lost. r=johannh
https://hg.mozilla.org/integration/autoland/rev/5dc18a9c4af8
ContentBlocking: Set hasException attribute in onLocationChange. r=johannh
https://hg.mozilla.org/integration/autoland/rev/974fd62d4135
Add a test for the toggle switch in the protections panel. r=johannh

Backed out 4 changesets (bug 1551902) for failing at browser_protections_UI.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/a71da3e33bff5559f980e45baa510d7216e76e08

**Push with failures:**https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=974fd62d41351d3927dfe5e7d70845600ae377c9&selectedJob=249935980

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=249935980&repo=autoland&lineNumber=2443

Log snippet:

[task 2019-06-04T14:04:01.670Z] 14:04:01 INFO - *** Start BrowserChrome Test Results ***
[task 2019-06-04T14:04:01.868Z] 14:04:01 INFO - checking window state
[task 2019-06-04T14:04:01.937Z] 14:04:01 INFO - TEST-START | browser/base/content/test/siteProtections/browser_protections_UI.js
[task 2019-06-04T14:04:05.587Z] 14:04:05 INFO - TEST-INFO | started process screentopng
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - TEST-INFO | screentopng: exit 0
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - Buffered messages logged at 14:04:01
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - Entering test bound testToggleSwitch
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - Buffered messages logged at 14:04:04
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | TP Switch should be enabled -
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - Buffered messages logged at 14:04:05
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | TP Switch should be disabled -
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - Buffered messages finished
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - [Exception... "Could not convert JavaScript argument arg 0 [nsIPermissionManager.remove]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js :: testToggleSwitch :: line 19" data: no]
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - Stack trace:
[task 2019-06-04T14:04:06.722Z] 14:04:06 INFO - testToggleSwitch@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:19:18
[task 2019-06-04T14:04:06.723Z] 14:04:06 INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1115:34
[task 2019-06-04T14:04:06.723Z] 14:04:06 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1143:12
[task 2019-06-04T14:04:06.723Z] 14:04:06 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1004:14
[task 2019-06-04T14:04:06.723Z] 14:04:06 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2019-06-04T14:04:06.723Z] 14:04:06 INFO - Leaving test bound testToggleSwitch

Flags: needinfo?(nhnt11)
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/29cbb321a610
Implement Tracking Protection toggle section in Protections Panel. r=johannh
https://hg.mozilla.org/integration/autoland/rev/212cfe3c1893
Hide protections panel when focus is lost. r=johannh
https://hg.mozilla.org/integration/autoland/rev/4c8afa61cbec
ContentBlocking: Set hasException attribute in onLocationChange. r=johannh
https://hg.mozilla.org/integration/autoland/rev/762ba28bc409
Add a test for the toggle switch in the protections panel. r=johannh
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f397460e4d9d
Backed out 4 changesets for browser-chrome failure at browser/base/content/test/trackingUI/browser_trackingUI_cryptominers.js. On a CLOSED TREE

Backed out 4 changesets (Bug 1551902) for browser-chrome failure at browser/base/content/test/trackingUI/browser_trackingUI_cryptominers.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=250049873&revision=762ba28bc409af7e664ca6a76537b105b9a44f95

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250049129&repo=autoland&lineNumber=12412

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=250049873&revision=f397460e4d9d505b552d576f2b5393183ab602f8

[task 2019-06-04T23:27:02.976Z] 23:27:02     INFO - TEST-START | dom/media/webaudio/test/test_bug827541.html
[task 2019-06-04T23:27:03.114Z] 23:27:03     INFO - GECKO(2590) | AddressSanitizer:DEADLYSIGNAL
[task 2019-06-04T23:27:03.115Z] 23:27:03     INFO - GECKO(2590) | =================================================================
[task 2019-06-04T23:27:03.116Z] 23:27:03    ERROR - GECKO(2590) | ==2659==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000020 (pc 0x7fcaf832957f bp 0x7ffc7f1fa270 sp 0x7ffc7f1fa140 T0)
[task 2019-06-04T23:27:03.116Z] 23:27:03     INFO - GECKO(2590) | ==2659==The signal is caused by a READ memory access.
[task 2019-06-04T23:27:03.117Z] 23:27:03     INFO - GECKO(2590) | ==2659==Hint: address points to the zero page.
[task 2019-06-04T23:27:03.758Z] 23:27:03     INFO - GECKO(2590) |     #0 0x7fcaf832957e in get /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:268:27
[task 2019-06-04T23:27:03.760Z] 23:27:03     INFO - GECKO(2590) |     #1 0x7fcaf832957e in operator-> /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RefPtr.h:298
[task 2019-06-04T23:27:03.762Z] 23:27:03     INFO - GECKO(2590) |     #2 0x7fcaf832957e in NodePrincipal /builds/worker/workspace/build/src/dom/base/nsINode.h:855
[task 2019-06-04T23:27:03.764Z] 23:27:03     INFO - GECKO(2590) |     #3 0x7fcaf832957e in SiteAutoplayPerm /builds/worker/workspace/build/src/dom/media/AutoplayPolicy.cpp:69
[task 2019-06-04T23:27:03.765Z] 23:27:03     INFO - GECKO(2590) |     #4 0x7fcaf832957e in mozilla::dom::AutoplayPolicy::IsAllowedToPlay(mozilla::dom::AudioContext const&) /builds/worker/workspace/build/src/dom/media/AutoplayPolicy.cpp:248
[task 2019-06-04T23:27:03.783Z] 23:27:03     INFO - GECKO(2590) |     #5 0x7fcaf8c484ba in mozilla::dom::AudioContext::AudioContext(nsPIDOMWindowInner*, bool, unsigned int, unsigned int, float) /builds/worker/workspace/build/src/dom/media/webaudio/AudioContext.cpp:173:31
[task 2019-06-04T23:27:03.785Z] 23:27:03     INFO - GECKO(2590) |     #6 0x7fcaf8c4ac38 in mozilla::dom::AudioContext::Constructor(mozilla::dom::GlobalObject const&, mozilla::dom::AudioContextOptions const&, mozilla::ErrorResult&) /builds/worker/workspace/build/src/dom/media/webaudio/AudioContext.cpp:282:11
[task 2019-06-04T23:27:03.835Z] 23:27:03     INFO - GECKO(2590) |     #7 0x7fcaf52ebf3f in mozilla::dom::AudioContext_Binding::_constructor(JSContext*, unsigned int, JS::Value*) /builds/worker/workspace/build/src/obj-firefox/dom/bindings/AudioContextBinding.cpp:648:58
[task 2019-06-04T23:27:03.856Z] 23:27:03     INFO - GECKO(2590) |     #8 0x7fcafdd12ad7 in CallJSNative /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:448:13
[task 2019-06-04T23:27:03.859Z] 23:27:03     INFO - GECKO(2590) |     #9 0x7fcafdd12ad7 in CallJSNativeConstructor /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:464
[task 2019-06-04T23:27:03.861Z] 23:27:03     INFO - GECKO(2590) |     #10 0x7fcafdd12ad7 in InternalConstruct(JSContext*, js::AnyConstructArgs const&) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:657
[task 2019-06-04T23:27:03.862Z] 23:27:03     INFO - GECKO(2590) |     #11 0x7fcafdcef444 in Interpret(JSContext*, js::RunState&) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:3078:16
[task 2019-06-04T23:27:03.865Z] 23:27:03     INFO - GECKO(2590) |     #12 0x7fcafdcd9058 in js::RunScript(JSContext*, js::RunState&) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:425:10
[task 2019-06-04T23:27:03.867Z] 23:27:03     INFO - GECKO(2590) |     #13 0x7fcafdd156ac in js::ExecuteKernel(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value const&, js::AbstractFramePtr, JS::Value*) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:787:13
[task 2019-06-04T23:27:03.869Z] 23:27:03     INFO - GECKO(2590) |     #14 0x7fcafdd15e59 in js::Execute(JSContext*, JS::Handle<JSScript*>, JSObject&, JS::Value*) /builds/worker/workspace/build/src/js/src/vm/Interpreter.cpp:820:10
[task 2019-06-04T23:27:03.953Z] 23:27:03     INFO - GECKO(2590) |     #15 0x7fcafdf9e5ba in ExecuteScript(JSContext*, JS::Handle<JS::StackGCVector<JSObject*, js::TempAllocPolicy> >, JS::Handle<JSScript*>, JS::Value*) /builds/worker/workspace/build/src/js/src/vm/CompilationAndEvaluation.cpp:468:10
[task 2019-06-04T23:27:03.972Z] 23:27:03     INFO - GECKO(2590) |     #16 0x7fcaf512b4f4 in nsJSUtils::ExecutionContext::ExecScript() /builds/worker/workspace/build/src/dom/base/nsJSUtils.cpp:387:8
[task 2019-06-04T23:27:03.989Z] 23:27:03     INFO - GECKO(2590) |     #17 0x7fcaf9aa76b3 in mozilla::dom::ExecuteCompiledScript(JSContext*, mozilla::dom::ScriptLoadRequest*, nsJSUtils::ExecutionContext&) /builds/worker/workspace/build/src/dom/script/ScriptLoader.cpp:2548:16
[task 2019-06-04T23:27:03.992Z] 23:27:03     INFO - GECKO(2590) |     #18 0x7fcaf9aa4751 in mozilla::dom::ScriptLoader::EvaluateScript(mozilla::dom::ScriptLoadRequest*) /builds/worker/workspace/build/src/dom/script/ScriptLoader.cpp:2768:20
[task 2019-06-04T23:27:03.993Z] 23:27:03     INFO - GECKO(2590) |     #19 0x7fcaf9a9d0d8 in mozilla::dom::ScriptLoader::ProcessRequest(mozilla::dom::ScriptLoadRequest*) /builds/worker/workspace/build/src/dom/script/ScriptLoader.cpp:2275:10

Sorry for the mixup, edited.

Daniel, I think you pasted information for the wrong backout. You referenced bug 1556857 but this is bug 1551902. Could you please double-check? :)

browser_trackingUI_cryptominers.js was mentioned to be failing in the backout commit, so I went ahead and made a patch to fix that. It would be useful to see the push in treeherder to see if any other test failed. I was surprised - I thought I did a try push for this, and I remember seeing no relevant failures, but apparently I didn't paste the link in the bug... hmph.

Flags: needinfo?(dvarga)
Flags: needinfo?(dvarga)
Flags: needinfo?(nhnt11)
Blocks: 1556271
Attachment #9069822 - Attachment description: Bug 1551902 - Update cryptominers UI test to expect visible icon when there's an exception. r=johannh → Bug 1551902 - Update tracking UI tests to expect visible icon when there's an exception. r=johannh
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a24793c196ea
Implement Tracking Protection toggle section in Protections Panel. r=johannh
https://hg.mozilla.org/integration/autoland/rev/62c30d2773bc
Hide protections panel when focus is lost. r=johannh
https://hg.mozilla.org/integration/autoland/rev/b8c5f94d8702
ContentBlocking: Set hasException attribute in onLocationChange. r=johannh
https://hg.mozilla.org/integration/autoland/rev/d99cbd9e6a03
Add a test for the toggle switch in the protections panel. r=johannh
https://hg.mozilla.org/integration/autoland/rev/cc4570fed452
Update tracking UI tests to expect visible icon when there's an exception. r=johannh
You need to log in before you can comment on or make changes to this bug.